Restore thread name consistency for webrtc/p2p/ .

Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
Committed: https://crrev.com/27c3d5b65202255b3d9a253872917b504d1ed408
Cr-Commit-Position: refs/heads/master@{#14646}

[johan, 2016-10-05 13:11:14]

Description was changed from

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

This is a follow-up for CLs
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
==========

to

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
==========

[johan, 2016-10-05 13:54:38]

johan@webrtc.org changed reviewers:
+ danilchap@webrtc.org, honghaiz@webrtc.org

[danilchap, 2016-10-05 14:56:13]

lgtm

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/dtlstrans...
File webrtc/p2p/base/dtlstransportchannel.h (right):

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportchannel.h:227: rtc::Thread* network_thread_;  //
Everything should occur on this thread.
this variable is used only to validate everything is run on this thread.
Might make sense to replace it with ThreadChecker (base/thread_checker):
rtc::ThreadChecker network_thread_checker_;
in .cc:
RTC_DCHECK_RUN_ON(&network_thread_checker_); instead of ASSERTs

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/transport...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/transport...
webrtc/p2p/base/transportcontroller_unittest.cc:55: network_thread_.reset(new
rtc::Thread());
may be
network_thread_ = rtc::Thread::CreateWithSocketServer();
(it would be exactly same call underneath, just more explicit socket server part
is needed)

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/quic/quictrans...
File webrtc/p2p/quic/quictransportchannel.h (right):

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/quic/quictrans...
webrtc/p2p/quic/quictransportchannel.h:270: rtc::Thread* network_thread_;
same as for dtlstransportchannel: might be better to replace with ThreadChecker

[johan, 2016-10-05 16:13:24]

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/dtlstrans...
File webrtc/p2p/base/dtlstransportchannel.h (right):

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportchannel.h:227: rtc::Thread* network_thread_;  //
Everything should occur on this thread.
On 2016/10/05 14:56:13, danilchap wrote:
> this variable is used only to validate everything is run on this thread.
> Might make sense to replace it with ThreadChecker (base/thread_checker):
> rtc::ThreadChecker network_thread_checker_;
> in .cc:
> RTC_DCHECK_RUN_ON(&network_thread_checker_); instead of ASSERTs

Basically I agree on preferring RTC_DCHECK family of macros over ASSERTs. As the
rtc::ThreadChecker at some point internally uses rtc::CritScope locks it is
possible to have impact on runtime behaviour for debug builds. It is still worth
a try, but I prefer to not mixing the move from ASSERTs to ThreadChecker into
this CL.

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/transport...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2396513003/diff/20001/webrtc/p2p/base/transport...
webrtc/p2p/base/transportcontroller_unittest.cc:55: network_thread_.reset(new
rtc::Thread());
On 2016/10/05 14:56:13, danilchap wrote:
> may be
> network_thread_ = rtc::Thread::CreateWithSocketServer();
> (it would be exactly same call underneath, just more explicit socket server
part
> is needed)

Acknowledged.

[johan, 2016-10-14 16:10:38]

ping honghaiz3

[honghaiz3, 2016-10-14 19:31:37]

lgtm. Thanks for doing this!

[johan, 2016-10-17 07:20:59]

The CQ bit was checked by johan@webrtc.org

[johan, 2016-10-17 07:20:59]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2396513003/#ps40001 (title:
"Explicit call rtc::Thread::CreateWithSocketServer() for unit test.")

[commit-bot: I haz the power, 2016-10-17 07:21:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-17 07:55:00]

Description was changed from

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
==========

to

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
==========

[commit-bot: I haz the power, 2016-10-17 07:55:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-17 07:55:10]

Description was changed from

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432
==========

to

==========
Restore thread name consistency for webrtc/p2p/ .

Thread variables were named worker_thread, while they actually
reference the network_thread introduced with the CLs below.

Original introduction of network_thread:
https://codereview.webrtc.org/1895813003
https://codereview.webrtc.org/1903393004

Renming of woker_thread_ to network_thread_ in P2PTransportChannel:
https://codereview.webrtc.org/2378573003

BUG=webrtc:6432

Committed: https://crrev.com/27c3d5b65202255b3d9a253872917b504d1ed408
Cr-Commit-Position: refs/heads/master@{#14646}
==========

[commit-bot: I haz the power, 2016-10-17 07:55:11]

Patchset 3 (id:??) landed as
https://crrev.com/27c3d5b65202255b3d9a253872917b504d1ed408
Cr-Commit-Position: refs/heads/master@{#14646}