Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2378573003: Rename P2PTransportChannel worker_thread_ to network_thread_. (Closed)

Created:
4 years, 2 months ago by johan
Modified:
4 years, 2 months ago
Reviewers:
danilchap, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename P2PTransportChannel worker_thread_ to network_thread_. Restore consistency of thread names in ThreadController and P2PTransportChannel. This is a follow-up for https://codereview.webrtc.org/1895813003 and https://codereview.webrtc.org/1903393004. BUG=webrtc:6432 Committed: https://crrev.com/0fd22ef0aec4841094065f527f9c92ff9690a322 Cr-Commit-Position: refs/heads/master@{#14426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 26 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
danilchap
lgtm
4 years, 2 months ago (2016-09-28 11:30:30 UTC) #6
danilchap
lgtm lgtm
4 years, 2 months ago (2016-09-28 11:30:31 UTC) #7
honghaiz3
lgtm
4 years, 2 months ago (2016-09-28 16:35:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378573003/1
4 years, 2 months ago (2016-09-29 08:02:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 08:19:23 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 08:19:36 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fd22ef0aec4841094065f527f9c92ff9690a322
Cr-Commit-Position: refs/heads/master@{#14426}

Powered by Google App Engine
This is Rietveld 408576698