Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1895813003: Renames TransportController worker_thread to network_thread. (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1, stefan-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renames TransportController worker_thread to network_thread. function suffix '_w' changes to '_n' BUG=webrtc:5645 R=pbos@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/7f216b71aac44dfd346ef8ad5edfc9b450d5b77d Cr-Commit-Position: refs/heads/master@{#12694}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -175 lines) Patch
M webrtc/p2p/base/faketransportcontroller.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 1 4 chunks +33 lines, -33 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 1 25 chunks +119 lines, -118 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/channel.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
danilchap
This CL is part of introducing Network Thread to improve bwe prober. (https://codereview.webrtc.org/1888903003/). thread and ...
4 years, 8 months ago (2016-04-19 10:56:28 UTC) #1
danilchap
follow-up of https://codereview.webrtc.org/1903393004/ pure renaming, no functionality changes
4 years, 7 months ago (2016-05-11 18:13:31 UTC) #4
pbos-webrtc
lgtm
4 years, 7 months ago (2016-05-11 18:16:22 UTC) #5
pthatcher1
lgtm
4 years, 7 months ago (2016-05-12 04:24:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895813003/20001
4 years, 7 months ago (2016-05-12 05:35:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13214)
4 years, 7 months ago (2016-05-12 05:42:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895813003/20001
4 years, 7 months ago (2016-05-12 07:01:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13222)
4 years, 7 months ago (2016-05-12 07:10:38 UTC) #15
danilchap
4 years, 7 months ago (2016-05-12 07:20:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7f216b71aac44dfd346ef8ad5edfc9b450d5b77d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698