Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2377243002: Add support for CSSValue->CSSSimpleLength when it is a percentage. (Closed)

Created:
4 years, 2 months ago by meade_UTC10
Modified:
4 years, 2 months ago
Reviewers:
rjwright, rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for CSSValue->CSSSimpleLength when it is a percentage. Incidentally fix issue where percent-typed CSSSimpleLengths were returning "%" instead of "percent" from type(). Also added a test that you can't set value or type, as setting type was removed in https://codereview.chromium.org/2373233002 Spec: https://drafts.css-houdini.org/css-typed-om/#lengthvalue-objects BUG=545318 Committed: https://crrev.com/83868eb38df6966ea4ebdc8f270b204c3f9429d5 Cr-Commit-Position: refs/heads/master@{#422059}

Patch Set 1 #

Patch Set 2 : Update test expectations #

Messages

Total messages: 16 (10 generated)
meade_UTC10
4 years, 2 months ago (2016-09-29 08:49:47 UTC) #5
rune
lgtm
4 years, 2 months ago (2016-09-29 09:18:27 UTC) #6
meade_UTC10
Thanks Rune!
4 years, 2 months ago (2016-09-30 06:22:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377243002/20001
4 years, 2 months ago (2016-09-30 06:22:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 07:48:24 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:50:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83868eb38df6966ea4ebdc8f270b204c3f9429d5
Cr-Commit-Position: refs/heads/master@{#422059}

Powered by Google App Engine
This is Rietveld 408576698