third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp - Issue 2377243002: Add support for CSSValue->CSSSimpleLength when it is a percentage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Issue 2377243002: Add support for CSSValue->CSSSimpleLength when it is a percentage. (Closed)

Patch Set: Update test expectations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp b/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

index 3dd43b33f27318d2e9a2f2bdef3ef7ab0193be12..7b0ab807be203c68c4ea61b99628646711aaa88b 100644

--- a/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

@@ -23,7 +23,7 @@ CSSStyleValue* styleValueForPrimitiveValue(const CSSPrimitiveValue& primitiveVal

{

if (primitiveValue.isNumber())

return CSSNumberValue::create(primitiveValue.getDoubleValue());

- if (primitiveValue.isLength())

+ if (primitiveValue.isLength() || primitiveValue.isPercentage())

return CSSSimpleLength::fromCSSValue(primitiveValue);

return nullptr;

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp ('k') | no next file » | no next file with comments »