Issue 2377023002: Now pass ADM as a constructor argument to audio_state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2377023002: Now pass ADM as a constructor argument to audio_state. (Closed)

Created:
4 years, 2 months ago by aleloi

Modified:
4 years, 2 months ago

Reviewers:
the sun

CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Now pass ADM as a constructor argument to audio_state. BUG=webrtc:6346

Patch Set 1 : Removed audio_transport() mock calls in tests. #

Total comments: 2

Patch Set 2 : basically reverted everything except for setting the adm field of config in webrtcvoiceengine #

Patch Set 3 : changing back wvoe unit test #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
M	webrtc/audio/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/audio/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/audio/webrtc_audio.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/call/call_perf_tests.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/media/engine/webrtcvoiceengine.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 2383023003 Patch 20001

Issue 2383023003 Patch 40001

Issue 2383023003 Patch 60001

Issue 2383023003 Patch 80001

Issue 2383023003 Patch 100001

Issue 2383023003 Patch 120001

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

the sun

4 years, 2 months ago (2016-09-29 16:15:07 UTC) #4

https://codereview.webrtc.org/2377023002/diff/20001/webrtc/api/call/audio_sta...
File webrtc/api/call/audio_state.h (right):

https://codereview.webrtc.org/2377023002/diff/20001/webrtc/api/call/audio_sta...
webrtc/api/call/audio_state.h:37: AudioDeviceModule* audio_device_module =
nullptr;
Look at me!

https://codereview.webrtc.org/2377023002/diff/20001/webrtc/api/call/audio_sta...
webrtc/api/call/audio_state.h:42: webrtc::AudioDeviceModule* adm);
Can you use the one in Config instead?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages