Issue 2383023003: Test upload to see if the ADM is passed correctly to audio_state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2383023003: Test upload to see if the ADM is passed correctly to audio_state. (Closed)

Created:
4 years, 2 months ago by aleloi

Modified:
3 years, 10 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Test upload to see if the ADM is passed correctly to audio_state. Note: this is not up for review and will not be pushed to the tree. The purpose of this change is to run the tests on the bots to ensure that the ADM is passed correctly in all unit tests (which you can't write a test for). This is part of the refactoring work to integrate the new audio mixer into webrtc. BUG=none

Patch Set 1 #

Patch Set 2 : "rebase" #

Patch Set 3 : did we really need this? #

Patch Set 4 : better way to check if this was needed: ignore the config value in audio_state #

Patch Set 5 : forgot to initiazile #

Patch Set 6 : Added expectation of fkn voe.audio_transport() invocation. #

Patch Set 7 : forgot send-stream config #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -2 lines)			Patch
M	webrtc/audio/audio_receive_stream_unittest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/audio/audio_send_stream_unittest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	webrtc/audio/audio_state.h	View	1 2 3 4	3 chunks	+5 lines, -0 lines	0 comments	Download
M	webrtc/audio/audio_state.cc	View	1 2 3	3 chunks	+90 lines, -0 lines	0 comments	Download
M	webrtc/audio/audio_state_unittest.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webrtc/call/call_perf_tests.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/media/engine/webrtcvoiceengine.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2377023002 Patch 60001