Format all Java in WebRTC.

Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org

Committed: https://crrev.com/b6760f9e4442410f2bcb6090b3b89bf709e2fce2
Cr-Commit-Position: refs/heads/master@{#14432}

[sakal, 2016-09-28 11:36:45]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-09-28 11:36:46]

PTAL

[henrika_webrtc, 2016-09-28 11:40:43]

What tool did you use here?

[magjed_webrtc, 2016-09-28 11:53:41]

On 2016/09/28 11:40:43, henrika_webrtc wrote:
> What tool did you use here?

git cl format. It should work now, see
https://bugs.chromium.org/p/webrtc/issues/detail?id=6419 for more info.

[magjed_webrtc, 2016-09-28 13:45:05]

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/EglBase.java:40: public static final
int[] CONFIG_PLAIN = {EGL10.EGL_RED_SIZE, 8, EGL10.EGL_GREEN_SIZE, 8,
I don't like this change. Revert it manually and add
// clang-format off
...
// clang-format on
for this block.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java:29: private static
final String VERTEX_SHADER_STRING = "varying vec2 interp_tc;\n"
I don't like this change - revert and add // clang-format off / clang-format on

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java:79: private static
final FloatBuffer FULL_RECTANGLE_BUF = GlUtil.createFloatBuffer(new float[] {
this change is fine though

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java:85:
CodecCapabilities.COLOR_FormatYUV420Planar,
CodecCapabilities.COLOR_FormatYUV420SemiPlanar,
You should probably revert this change as well.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:135: new
String[] {// HW H.264 encoder on below devices has poor bitrate control - actual
Revert this change. Maybe just move the comment out from the array.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:146: private
static final int[] supportedColorList =
{CodecCapabilities.COLOR_FormatYUV420Planar,
Revert.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/RendererCommon.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/RendererCommon.java:120: return new
float[] {1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1};
Revert these changes.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/SurfaceTextureHelper.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/SurfaceTextureHelper.java:101: private
static final String VERTEX_SHADER = "varying vec2 interp_tc;\n"
move "varying vec2 interp_tc;\n" to the next line as before.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/VideoCapturer.java:115: @Deprecated void
onOutputFormatRequest(int width, int height, int framerate);
This looks strange. I'm about to delete it anyway though.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/VideoRenderer.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/VideoRenderer.java:64: samplingMatrix =
new float[] {1, 0, 0, 0, 0, -1, 0, 0, 0, 0, 1, 0, 0, 1, 0, 1};
Revert.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
File webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java:336: + "\n   
for: " + Arrays.toString(stillWaitingForExpectations.toArray()));
Revert.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
File webrtc/api/androidtests/src/org/webrtc/RendererCommonTest.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/RendererCommonTest.java:98:
MoreAsserts.assertEquals(
revert.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/base/java/src/org/...
File webrtc/base/java/src/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/base/java/src/org/...
webrtc/base/java/src/org/webrtc/ThreadUtils.java:45: public interface
BlockingOperation { void run() throws InterruptedException; }
interesting format choice, but I guess it's fine

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java
(right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java:175:
public void onSharedPreferenceChanged(SharedPreferences sharedPreferences,
String key) {
revert

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/examples/androidju...
File
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java
(right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/examples/androidju...
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java:65:
final String[] ipAddresses =
revert.

[sakal, 2016-09-28 15:05:14]

Reverted except where commented otherwise.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java:85:
CodecCapabilities.COLOR_FormatYUV420Planar,
CodecCapabilities.COLOR_FormatYUV420SemiPlanar,
On 2016/09/28 13:45:04, magjed_webrtc wrote:
> You should probably revert this change as well.

I kept it.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
File webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/android/java/s...
webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java:146: private
static final int[] supportedColorList =
{CodecCapabilities.COLOR_FormatYUV420Planar,
On 2016/09/28 13:45:04, magjed_webrtc wrote:
> Revert.

I don't think is bad enough to revert.

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
File webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java (right):

https://codereview.webrtc.org/2377003002/diff/20001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java:336: + "\n   
for: " + Arrays.toString(stillWaitingForExpectations.toArray()));
On 2016/09/28 13:45:04, magjed_webrtc wrote:
> Revert.

I am fine with this.

[magjed_webrtc, 2016-09-28 15:18:04]

lgtm

[sakal, 2016-09-29 07:40:20]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-29 07:40:27]

The CQ bit was unchecked by sakal@webrtc.org

[sakal, 2016-09-29 09:40:53]

Description was changed from

==========
Format all Java in WebRTC.

BUG=webrtc:6419
==========

to

==========
Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org
==========

[sakal, 2016-09-29 09:40:53]

sakal@webrtc.org changed reviewers:
+ henrika@webrtc.org

[sakal, 2016-09-29 09:41:25]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-29 09:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 09:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 09:43:08]

Try jobs failed on following builders:
  ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/954)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/13270)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/18594)
  linux_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/18118)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[sakal, 2016-09-29 09:51:20]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-09-29 09:51:21]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2377003002/#ps80001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-09-29 09:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 11:12:47]

Description was changed from

==========
Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org
==========

to

==========
Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org
==========

[commit-bot: I haz the power, 2016-09-29 11:12:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-29 11:12:55]

Description was changed from

==========
Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org
==========

to

==========
Format all Java in WebRTC.

BUG=webrtc:6419
TBR=henrika@webrtc.org

Committed: https://crrev.com/b6760f9e4442410f2bcb6090b3b89bf709e2fce2
Cr-Commit-Position: refs/heads/master@{#14432}
==========

[commit-bot: I haz the power, 2016-09-29 11:12:57]

Patchset 5 (id:??) landed as
https://crrev.com/b6760f9e4442410f2bcb6090b3b89bf709e2fce2
Cr-Commit-Position: refs/heads/master@{#14432}