Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2370993003: Reland of Delete VideoFrameFactory, CapturedFrame, and related code. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, perkj_webrtc, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete VideoFrameFactory, CapturedFrame, and related code. (patchset #1 id:1 of https://codereview.webrtc.org/2357113002/ ) Reason for revert: Downstream code is being fixed. Original issue's description: > Revert of Delete VideoFrameFactory, CapturedFrame, and related code. (patchset #9 id:160001 of https://codereview.webrtc.org/2262443003/ ) > > Reason for revert: > Breaks downstream testcode, still using CapturedFrame. > > Original issue's description: > > Delete VideoFrameFactory, CapturedFrame, and related code. > > > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/66ac50e58c790624d51ede10ae438cbadbca9d2e > > Cr-Commit-Position: refs/heads/master@{#14315} > > TBR=pthatcher@webrtc.org,perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/66492210e57ee8efce2ad4d45a8781df1fcaa5e3 > Cr-Commit-Position: refs/heads/master@{#14320} TBR=pthatcher@webrtc.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5682 Committed: https://crrev.com/f5297a019ea6de709a2bb94793d637bb44538931 Cr-Commit-Position: refs/heads/master@{#14453}

Patch Set 1 #

Patch Set 2 : Resolve conflict in webrtc/media/BUILD.gn. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -615 lines) Patch
M webrtc/media/BUILD.gn View 1 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 1 3 chunks +25 lines, -40 lines 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 1 7 chunks +16 lines, -17 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 9 chunks +2 lines, -53 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 6 chunks +22 lines, -103 lines 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
D webrtc/media/base/videoframefactory.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/media/base/videoframefactory.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 3 chunks +4 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 2 chunks +0 lines, -72 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nisse-webrtc
Created Reland of Delete VideoFrameFactory, CapturedFrame, and related code.
4 years, 2 months ago (2016-09-27 11:40:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2370993003/260001
4 years, 2 months ago (2016-09-30 06:45:23 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years, 2 months ago (2016-09-30 08:34:30 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:34:42 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5297a019ea6de709a2bb94793d637bb44538931
Cr-Commit-Position: refs/heads/master@{#14453}

Powered by Google App Engine
This is Rietveld 408576698