Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2357113002: Revert of Delete VideoFrameFactory, CapturedFrame, and related code. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, perkj_webrtc, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete VideoFrameFactory, CapturedFrame, and related code. (patchset #9 id:160001 of https://codereview.webrtc.org/2262443003/ ) Reason for revert: Breaks downstream testcode, still using CapturedFrame. Original issue's description: > Delete VideoFrameFactory, CapturedFrame, and related code. > > BUG=webrtc:5682 > > Committed: https://crrev.com/66ac50e58c790624d51ede10ae438cbadbca9d2e > Cr-Commit-Position: refs/heads/master@{#14315} TBR=pthatcher@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/66492210e57ee8efce2ad4d45a8781df1fcaa5e3 Cr-Commit-Position: refs/heads/master@{#14320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -81 lines) Patch
M webrtc/media/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 3 chunks +40 lines, -25 lines 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 7 chunks +17 lines, -16 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 9 chunks +53 lines, -2 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 6 chunks +103 lines, -22 lines 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
A webrtc/media/base/videoframefactory.h View 1 chunk +63 lines, -0 lines 0 comments Download
A webrtc/media/base/videoframefactory.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 3 chunks +11 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +72 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframefactory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframefactory.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +109 lines, -0 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Revert of Delete VideoFrameFactory, CapturedFrame, and related code.
4 years, 3 months ago (2016-09-21 09:09:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2357113002/1
4 years, 3 months ago (2016-09-21 09:09:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:09:56 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66492210e57ee8efce2ad4d45a8781df1fcaa5e3 Cr-Commit-Position: refs/heads/master@{#14320}
4 years, 3 months ago (2016-09-21 09:10:05 UTC) #6
nisse-webrtc
4 years, 2 months ago (2016-09-27 11:40:55 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2370993003/ by nisse@webrtc.org.

The reason for reverting is: Downstream code is being fixed..

Powered by Google App Engine
This is Rietveld 408576698