Make 'webrtc' target a complete static library on Linux, Android and Windows

Make 'webrtc' target a complete static library on Linux, Android and Windows

It's currently not possible on Mac and iOS due to libtool. See webrtc:6418
for more info.

BUG=webrtc:6418
NOTRY=True

Review-Url: https://codereview.webrtc.org/2367313002
Cr-Commit-Position: refs/heads/master@{#16411}
Committed: https://chromium.googlesource.com/external/webrtc/+/a29d5ec613030e9eff897476b64ccab0c4e0f60a

[kjellander_webrtc, 2017-01-02 20:07:22]

Description was changed from

==========
Create complete static library of the 'webrtc' target.

BUG=webrtc:6418
NOTRY=True
==========

to

==========
Make 'webrtc' target a complete static library on Linux, Android and Windows

It's currently not possible on Mac and iOS due to libtool. See webrtc:6418
for more info.

BUG=webrtc:6418
NOTRY=True
==========

[kjellander_webrtc, 2017-01-30 07:56:50]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org, mbonadei@webrtc.org

[kjellander_webrtc, 2017-01-30 07:56:51]

Hmm, I'm unable to see any size difference for
out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.

Edward/Mirko: could you try on Windows to see if the libwebrtc.lib changes in
size?

[mbonadei, 2017-01-30 12:54:42]

On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> Hmm, I'm unable to see any size difference for
> out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.
> 
> Edward/Mirko: could you try on Windows to see if the libwebrtc.lib changes in
> size?

On master webrtc.lib is 2,328 bytes, while on a branch with this patch set it is
409,717,938 bytes.

[mbonadei, 2017-01-30 14:30:01]

On 2017/01/30 12:54:42, mbonadei wrote:
> On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> > Hmm, I'm unable to see any size difference for
> > out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.
> > 
> > Edward/Mirko: could you try on Windows to see if the libwebrtc.lib changes
in
> > size?
> 
> On master webrtc.lib is 2,328 bytes, while on a branch with this patch set it
is
> 409,717,938 bytes.

These are the results with the arg "is_debug=false".

On master webrtc.lib is 2,328 bytes, while on a branch with this patch set it is
183,599,718 bytes.

[kjellander_webrtc, 2017-01-31 21:40:46]

On 2017/01/30 14:30:01, mbonadei wrote:
> On 2017/01/30 12:54:42, mbonadei wrote:
> > On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> > > Hmm, I'm unable to see any size difference for
> > > out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.
> > > 
> > > Edward/Mirko: could you try on Windows to see if the libwebrtc.lib changes
> in
> > > size?
> > 
> > On master webrtc.lib is 2,328 bytes, while on a branch with this patch set
it
> is
> > 409,717,938 bytes.
> 
> These are the results with the arg "is_debug=false".
> 
> On master webrtc.lib is 2,328 bytes, while on a branch with this patch set it
is
> 183,599,718 bytes.

Thanks. I'm annoyed by the fact there's no difference on Linux. Any ideas?

[mbonadei, 2017-02-01 16:19:30]

On 2017/01/31 21:40:46, kjellander_webrtc wrote:
> On 2017/01/30 14:30:01, mbonadei wrote:
> > On 2017/01/30 12:54:42, mbonadei wrote:
> > > On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> > > > Hmm, I'm unable to see any size difference for
> > > > out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.
> > > > 
> > > > Edward/Mirko: could you try on Windows to see if the libwebrtc.lib
changes
> > in
> > > > size?
> > > 
> > > On master webrtc.lib is 2,328 bytes, while on a branch with this patch set
> it
> > is
> > > 409,717,938 bytes.
> > 
> > These are the results with the arg "is_debug=false".
> > 
> > On master webrtc.lib is 2,328 bytes, while on a branch with this patch set
it
> is
> > 183,599,718 bytes.
> 
> Thanks. I'm annoyed by the fact there's no difference on Linux. Any ideas?

I have just tried on my linux workstation and it seems that the size of the
files is different.
On master libwebrtc.a is  1214 bytes, while on a branch with this patch set it
is 28647542 bytes.

[kjellander_webrtc, 2017-02-01 17:14:16]

On 2017/02/01 16:19:30, mbonadei wrote:
> On 2017/01/31 21:40:46, kjellander_webrtc wrote:
> > On 2017/01/30 14:30:01, mbonadei wrote:
> > > On 2017/01/30 12:54:42, mbonadei wrote:
> > > > On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> > > > > Hmm, I'm unable to see any size difference for
> > > > > out/Release/obj/webrtc/libwebrtc.a on Linux with this change applied.
> > > > > 
> > > > > Edward/Mirko: could you try on Windows to see if the libwebrtc.lib
> changes
> > > in
> > > > > size?
> > > > 
> > > > On master webrtc.lib is 2,328 bytes, while on a branch with this patch
set
> > it
> > > is
> > > > 409,717,938 bytes.
> > > 
> > > These are the results with the arg "is_debug=false".
> > > 
> > > On master webrtc.lib is 2,328 bytes, while on a branch with this patch set
> it
> > is
> > > 183,599,718 bytes.
> > 
> > Thanks. I'm annoyed by the fact there's no difference on Linux. Any ideas?
> 
> I have just tried on my linux workstation and it seems that the size of the
> files is different.
> On master libwebrtc.a is  1214 bytes, while on a branch with this patch set it
> is 28647542 bytes.

Ah, you're right. I get the same results now that I tried again. I must have
been tired or something.
Then we should submit this - but I need a lgtm from someone first

[mbonadei, 2017-02-01 17:30:46]

On 2017/02/01 17:14:16, kjellander_webrtc wrote:
> On 2017/02/01 16:19:30, mbonadei wrote:
> > On 2017/01/31 21:40:46, kjellander_webrtc wrote:
> > > On 2017/01/30 14:30:01, mbonadei wrote:
> > > > On 2017/01/30 12:54:42, mbonadei wrote:
> > > > > On 2017/01/30 07:56:51, kjellander_webrtc wrote:
> > > > > > Hmm, I'm unable to see any size difference for
> > > > > > out/Release/obj/webrtc/libwebrtc.a on Linux with this change
applied.
> > > > > > 
> > > > > > Edward/Mirko: could you try on Windows to see if the libwebrtc.lib
> > changes
> > > > in
> > > > > > size?
> > > > > 
> > > > > On master webrtc.lib is 2,328 bytes, while on a branch with this patch
> set
> > > it
> > > > is
> > > > > 409,717,938 bytes.
> > > > 
> > > > These are the results with the arg "is_debug=false".
> > > > 
> > > > On master webrtc.lib is 2,328 bytes, while on a branch with this patch
set
> > it
> > > is
> > > > 183,599,718 bytes.
> > > 
> > > Thanks. I'm annoyed by the fact there's no difference on Linux. Any ideas?
> > 
> > I have just tried on my linux workstation and it seems that the size of the
> > files is different.
> > On master libwebrtc.a is  1214 bytes, while on a branch with this patch set
it
> > is 28647542 bytes.
> 
> Ah, you're right. I get the same results now that I tried again. I must have
> been tired or something.
> Then we should submit this - but I need a lgtm from someone first

lgtm

[kjellander_webrtc, 2017-02-02 07:18:07]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-02-02 07:18:10]

The CQ bit was unchecked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-02-02 07:18:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2017-02-02 07:48:35]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-02-02 07:48:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2367313002/#ps100001 (title:
"Fix bad rebase")

[commit-bot: I haz the power, 2017-02-02 07:48:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-02 07:51:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486021715778710,
"parent_rev": "24af66397e3e1919b801c8d56926263f90808ea1", "commit_rev":
"a29d5ec613030e9eff897476b64ccab0c4e0f60a"}

[commit-bot: I haz the power, 2017-02-02 07:51:15]

Description was changed from

==========
Make 'webrtc' target a complete static library on Linux, Android and Windows

It's currently not possible on Mac and iOS due to libtool. See webrtc:6418
for more info.

BUG=webrtc:6418
NOTRY=True
==========

to

==========
Make 'webrtc' target a complete static library on Linux, Android and Windows

It's currently not possible on Mac and iOS due to libtool. See webrtc:6418
for more info.

BUG=webrtc:6418
NOTRY=True

Review-Url: https://codereview.webrtc.org/2367313002
Cr-Commit-Position: refs/heads/master@{#16411}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a29d5ec613030e9eff897476b...
==========

[commit-bot: I haz the power, 2017-02-02 07:51:17]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/a29d5ec613030e9eff897476b...