Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: webrtc/BUILD.gn

Issue 2367313002: Make 'webrtc' target a complete static library on Linux, Android and Windows (Closed)
Patch Set: Fix bad rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index b46b80c71985b098d9248d9d90adf5268fd4e3ac..8969f13f10eba9f8f8e60546d1b203ae2a32eb57 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -227,16 +227,22 @@ if (!build_with_chromium) {
visibility = [ "//:default" ]
sources = [
- # TODO(kjellander): Remove this whenever possible. GN's static_library
- # target type requires at least one object to avoid errors linking.
- "no_op_function.cc",
-
# TODO(ossu): Keep this here until donwstream projects have updated.
# http://bugs.webrtc.org/6716
"call.h",
"config.h",
]
+ # complete_static_lib doesn't work on Mac since libtool cannot support
+ # multiple objects with the same filenames (https://bugs.webrtc.org/6418).
+ if (is_win || is_linux || is_android) {
+ complete_static_lib = true
+ } else {
+ # TODO(kjellander): Remove this whenever possible. GN's static_library
+ # target type requires at least one object to avoid errors linking.
+ sources += [ "no_op_function.cc" ]
+ }
+
defines = []
deps = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698