Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2359113002: GN: Remove non-existing header file: media/base/videorenderer.h (Closed)

Created:
4 years, 3 months ago by charujain
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Remove non-existing header file: media/base/videorenderer.h This header was removed in https://codereview.webrtc.org/1819103003 but the BUILD.gn file was not updated. BUG=webrtc:5949 NOTRY=True TBR=nisse@webrtc.org Committed: https://crrev.com/09baefeaf9f5f80d078b32afa9656ebdb1069c39 Cr-Commit-Position: refs/heads/master@{#14349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_webrtc
It's unfortunate there's no (known) way to have GN complain about missing files. lgtm
4 years, 3 months ago (2016-09-22 11:48:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2359113002/1
4 years, 3 months ago (2016-09-22 11:48:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 11:51:55 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/09baefeaf9f5f80d078b32afa9656ebdb1069c39 Cr-Commit-Position: refs/heads/master@{#14349}
4 years, 3 months ago (2016-09-22 11:52:01 UTC) #11
nisse-webrtc
4 years, 3 months ago (2016-09-22 11:54:37 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698