Delete cricket::VideoRenderer.

Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
Committed: https://crrev.com/1509fa1aa9cfb3be98b833ecf00ef466345dc05e
Cr-Commit-Position: refs/heads/master@{#12101}

[nisse-webrtc, 2016-03-22 13:53:23]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 13:53:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819103003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819103003/100001

[nisse-webrtc, 2016-03-22 13:57:08]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2016-03-22 13:57:08]

This cl deletes cricket::VideoRenderer (and cls to delete the remnants of it in
chrome are being landed).

This touches a couple of renderers under webrtc/media/devices. While my other
cl, deleting webrtc::VideoRendererInterface, touches renderers under
modules/video_render. It's unclear to me which parts of that code is used and/or
tested.

[commit-bot: I haz the power, 2016-03-22 14:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 14:54:58]

Dry run: This issue passed the CQ dry run.

[pbos-webrtc, 2016-03-22 18:28:44]

lgtm with a nit

https://codereview.webrtc.org/1819103003/diff/100001/webrtc/media/devices/gdi...
File webrtc/media/devices/gdivideorenderer.cc (right):

https://codereview.webrtc.org/1819103003/diff/100001/webrtc/media/devices/gdi...
webrtc/media/devices/gdivideorenderer.cc:142: SendMessage(handle(),
kRenderFrameMsg, reinterpret_cast<WPARAM>(frame), 0);
I prefer the abort on error way, because it looks like !SetSize is unexpected

[pthatcher1, 2016-03-23 04:53:05]

lgtm

[nisse-webrtc, 2016-03-23 07:11:13]

On 2016/03/22 18:28:44, pbos-webrtc wrote:
> lgtm with a nit
> 
>
https://codereview.webrtc.org/1819103003/diff/100001/webrtc/media/devices/gdi...
> File webrtc/media/devices/gdivideorenderer.cc (right):
> 
>
https://codereview.webrtc.org/1819103003/diff/100001/webrtc/media/devices/gdi...
> webrtc/media/devices/gdivideorenderer.cc:142: SendMessage(handle(),
> kRenderFrameMsg, reinterpret_cast<WPARAM>(frame), 0);
> I prefer the abort on error way, because it looks like !SetSize is unexpected

Abort how? RTC_CHECK? The only way SetSize can fail here is if
window_thread_->Start() fails. So it would make some sense to move the RTC_CHECK
there and delete the SetSize return value.

[perkj_webrtc, 2016-03-23 07:38:40]

lgtm if you are waiting for me...

[nisse-webrtc, 2016-03-23 09:38:55]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-23 09:38:56]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org, pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1819103003/#ps120001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-03-23 09:39:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819103003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819103003/120001

[commit-bot: I haz the power, 2016-03-23 09:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 09:56:24]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4363)

[nisse-webrtc, 2016-03-23 09:58:45]

Description was changed from

==========
Delete cricket::VideoRenderer.

BUG=webrtc:5426
==========

to

==========
Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
==========

[nisse-webrtc, 2016-03-23 10:00:37]

nisse@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[nisse-webrtc, 2016-03-23 10:00:50]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-03-23 10:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819103003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819103003/120001

[commit-bot: I haz the power, 2016-03-23 11:06:02]

Description was changed from

==========
Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
==========

to

==========
Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-03-23 11:06:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-23 11:06:11]

Description was changed from

==========
Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
==========

to

==========
Delete cricket::VideoRenderer.

TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426

Committed: https://crrev.com/1509fa1aa9cfb3be98b833ecf00ef466345dc05e
Cr-Commit-Position: refs/heads/master@{#12101}
==========

[commit-bot: I haz the power, 2016-03-23 11:06:12]

Patchset 7 (id:??) landed as
https://crrev.com/1509fa1aa9cfb3be98b833ecf00ef466345dc05e
Cr-Commit-Position: refs/heads/master@{#12101}