Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2354223002: Revert of Move MutableDataY{,U,V} methods to I420Buffer only. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, sdk-team_agora.io, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move MutableDataY{,U,V} methods to I420Buffer only. (patchset #14 id:260001 of https://codereview.webrtc.org/2278883002/ ) Reason for revert: Broke downstream application. Original issue's description: > Move MutableDataY{,U,V} methods to I420Buffer only. > > Deleted from the VideoFrameBuffer base class. > > BUG=webrtc:5921 > > Committed: https://crrev.com/5539ef6c03c273f39fadae41ace47fdc11ac6d60 > Cr-Commit-Position: refs/heads/master@{#14317} TBR=perkj@webrtc.org,magjed@webrtc.org,pthatcher@webrtc.org,honghaiz@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5921 Committed: https://crrev.com/776870a2599b8f43ad56987f9031690e3ccecde8 Cr-Commit-Position: refs/heads/master@{#14325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -537 lines) Patch
M webrtc/common_video/corevideo_frame_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/i420_buffer_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 2 chunks +9 lines, -3 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 3 chunks +4 lines, -7 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 5 chunks +76 lines, -80 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 2 chunks +28 lines, -26 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M webrtc/common_video/video_frame_buffer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 11 chunks +31 lines, -35 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 6 chunks +25 lines, -30 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 chunk +35 lines, -30 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/i420.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 24 chunks +130 lines, -126 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 8 chunks +84 lines, -83 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Revert of Move MutableDataY{,U,V} methods to I420Buffer only.
4 years, 3 months ago (2016-09-21 10:51:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354223002/1
4 years, 3 months ago (2016-09-21 10:51:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 10:52:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/776870a2599b8f43ad56987f9031690e3ccecde8 Cr-Commit-Position: refs/heads/master@{#14325}
4 years, 3 months ago (2016-09-21 10:52:25 UTC) #6
nisse-webrtc
4 years, 2 months ago (2016-09-26 06:56:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2372483002/ by nisse@webrtc.org.

The reason for reverting is: Downstream application now fixed..

Powered by Google App Engine
This is Rietveld 408576698