Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: webrtc/common_video/video_frame_buffer.cc

Issue 2354223002: Revert of Move MutableDataY{,U,V} methods to I420Buffer only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/common_video/video_frame.cc ('k') | webrtc/media/base/videoframe_unittest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 13 matching lines...) Expand all
24 namespace webrtc { 24 namespace webrtc {
25 25
26 namespace { 26 namespace {
27 27
28 int I420DataSize(int height, int stride_y, int stride_u, int stride_v) { 28 int I420DataSize(int height, int stride_y, int stride_u, int stride_v) {
29 return stride_y * height + (stride_u + stride_v) * ((height + 1) / 2); 29 return stride_y * height + (stride_u + stride_v) * ((height + 1) / 2);
30 } 30 }
31 31
32 } // namespace 32 } // namespace
33 33
34 uint8_t* VideoFrameBuffer::MutableDataY() {
35 RTC_NOTREACHED();
36 return nullptr;
37 }
38 uint8_t* VideoFrameBuffer::MutableDataU() {
39 RTC_NOTREACHED();
40 return nullptr;
41 }
42 uint8_t* VideoFrameBuffer::MutableDataV() {
43 RTC_NOTREACHED();
44 return nullptr;
45 }
46
34 VideoFrameBuffer::~VideoFrameBuffer() {} 47 VideoFrameBuffer::~VideoFrameBuffer() {}
35 48
36 I420Buffer::I420Buffer(int width, int height) 49 I420Buffer::I420Buffer(int width, int height)
37 : I420Buffer(width, height, width, (width + 1) / 2, (width + 1) / 2) { 50 : I420Buffer(width, height, width, (width + 1) / 2, (width + 1) / 2) {
38 } 51 }
39 52
40 I420Buffer::I420Buffer(int width, 53 I420Buffer::I420Buffer(int width,
41 int height, 54 int height,
42 int stride_y, 55 int stride_y,
43 int stride_u, 56 int stride_u,
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 void* WrappedI420Buffer::native_handle() const { 374 void* WrappedI420Buffer::native_handle() const {
362 return nullptr; 375 return nullptr;
363 } 376 }
364 377
365 rtc::scoped_refptr<VideoFrameBuffer> WrappedI420Buffer::NativeToI420Buffer() { 378 rtc::scoped_refptr<VideoFrameBuffer> WrappedI420Buffer::NativeToI420Buffer() {
366 RTC_NOTREACHED(); 379 RTC_NOTREACHED();
367 return nullptr; 380 return nullptr;
368 } 381 }
369 382
370 } // namespace webrtc 383 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/common_video/video_frame.cc ('k') | webrtc/media/base/videoframe_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698