Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: webrtc/common_video/i420_buffer_pool_unittest.cc

Issue 2354223002: Revert of Move MutableDataY{,U,V} methods to I420Buffer only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 buffer = nullptr; 45 buffer = nullptr;
46 // Check that the pool doesn't try to reuse buffers of incorrect size. 46 // Check that the pool doesn't try to reuse buffers of incorrect size.
47 buffer = pool.CreateBuffer(32, 16); 47 buffer = pool.CreateBuffer(32, 16);
48 EXPECT_EQ(32, buffer->width()); 48 EXPECT_EQ(32, buffer->width());
49 EXPECT_EQ(16, buffer->height()); 49 EXPECT_EQ(16, buffer->height());
50 EXPECT_NE(u_ptr, buffer->DataU()); 50 EXPECT_NE(u_ptr, buffer->DataU());
51 EXPECT_NE(v_ptr, buffer->DataV()); 51 EXPECT_NE(v_ptr, buffer->DataV());
52 } 52 }
53 53
54 TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) { 54 TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) {
55 rtc::scoped_refptr<I420Buffer> buffer; 55 rtc::scoped_refptr<VideoFrameBuffer> buffer;
56 { 56 {
57 I420BufferPool pool; 57 I420BufferPool pool;
58 buffer = pool.CreateBuffer(16, 16); 58 buffer = pool.CreateBuffer(16, 16);
59 } 59 }
60 EXPECT_EQ(16, buffer->width()); 60 EXPECT_EQ(16, buffer->width());
61 EXPECT_EQ(16, buffer->height()); 61 EXPECT_EQ(16, buffer->height());
62 // Try to trigger use-after-free errors by writing to y-plane. 62 // Try to trigger use-after-free errors by writing to y-plane.
63 memset(buffer->MutableDataY(), 0xA5, 16 * buffer->StrideY()); 63 memset(buffer->MutableDataY(), 0xA5, 16 * buffer->StrideY());
64 } 64 }
65 65
66 } // namespace webrtc 66 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/common_video/corevideo_frame_buffer.cc ('k') | webrtc/common_video/i420_video_frame_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698