Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2349663002: Revert of Optimize Android NV12 capture (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Optimize Android NV12 capture (patchset #2 id:20001 of https://codereview.webrtc.org/2317443003/ ) Reason for revert: Import breakage in g3. Original issue's description: > Optimize Android NV12 capture > > This CL optimizes the Android capture NV12 -> I420 + scaling code. For > example, when the input is 1280x720 and we adapt to 640x360, this CL: > - Reduces conversion time from 3.37 ms to 1.46 ms. > - Reduces memory footprint by 1 MB. > > BUG=webrtc:6319 > > Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2 > Cr-Commit-Position: refs/heads/master@{#14167} TBR=sakal@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -104 lines) Patch
M webrtc/api/androidvideotracksource.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/androidvideotracksource.cc View 2 chunks +28 lines, -59 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
magjed_webrtc
Created Revert of Optimize Android NV12 capture
4 years, 3 months ago (2016-09-16 07:37:06 UTC) #1
magjed_webrtc
4 years, 3 months ago (2016-09-16 07:38:30 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2341723005/ by magjed@webrtc.org.

The reason for reverting is: Import breakage has been fixed..

Powered by Google App Engine
This is Rietveld 408576698