Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2317443003: Optimize Android NV12 capture (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Optimize Android NV12 capture This CL optimizes the Android capture NV12 -> I420 + scaling code. For example, when the input is 1280x720 and we adapt to 640x360, this CL: - Reduces conversion time from 3.37 ms to 1.46 ms. - Reduces memory footprint by 1 MB. BUG=webrtc:6319 Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2 Cr-Commit-Position: refs/heads/master@{#14167}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update memory region comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -30 lines) Patch
M webrtc/api/androidvideotracksource.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/api/androidvideotracksource.cc View 2 chunks +58 lines, -27 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
magjed_webrtc
Sami - please take a look.
4 years, 3 months ago (2016-09-06 14:31:33 UTC) #3
sakal
lgtm https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/include/webrtc_libyuv.h File webrtc/common_video/libyuv/include/webrtc_libyuv.h (right): https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/include/webrtc_libyuv.h#newcode128 webrtc/common_video/libyuv/include/webrtc_libyuv.h:128: // separate U and V planes, and the ...
4 years, 3 months ago (2016-09-07 10:07:58 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/include/webrtc_libyuv.h File webrtc/common_video/libyuv/include/webrtc_libyuv.h (right): https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/include/webrtc_libyuv.h#newcode128 webrtc/common_video/libyuv/include/webrtc_libyuv.h:128: // separate U and V planes, and the size ...
4 years, 3 months ago (2016-09-08 11:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2317443003/20001
4 years, 3 months ago (2016-09-08 11:57:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/16621)
4 years, 3 months ago (2016-09-08 12:01:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2317443003/20001
4 years, 3 months ago (2016-09-09 15:27:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 16:09:52 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2 Cr-Commit-Position: refs/heads/master@{#14167}
4 years, 3 months ago (2016-09-09 16:09:56 UTC) #16
magjed_webrtc
On 2016/09/09 16:09:56, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 3 months ago (2016-09-16 07:36:39 UTC) #17
magjed_webrtc
4 years, 3 months ago (2016-09-16 07:37:06 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2349663002/ by magjed@webrtc.org.

The reason for reverting is: Import breakage in g3..

Powered by Google App Engine
This is Rietveld 408576698