Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
index fc3a810aacc1dcd49e04da447d43904aadaa5c52..c054c03d7152db5b754db2e949a1789cb65c36f1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc
@@ -10,6 +10,8 @@
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h"
+#include <utility>
+
#include "webrtc/base/checks.h"
#include "webrtc/base/logging.h"
#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
@@ -56,12 +58,12 @@ bool ExtendedJitterReport::Parse(const CommonHeader& packet) {
return true;
}
-bool ExtendedJitterReport::WithJitter(uint32_t jitter) {
- if (inter_arrival_jitters_.size() >= kMaxNumberOfJitters) {
- LOG(LS_WARNING) << "Max inter-arrival jitter items reached.";
+bool ExtendedJitterReport::SetJitters(std::vector<uint32_t> jitters) {
+ if (jitters.size() > kMaxNumberOfJitters) {
+ LOG(LS_WARNING) << "Too many inter-arrival jitter items.";
return false;
}
- inter_arrival_jitters_.push_back(jitter);
+ inter_arrival_jitters_ = std::move(jitters);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698