webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h - Issue 2348623003: Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2348623003: Unify rtcp packet setters (Closed)

Patch Set: Comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

index 7731988df47f151c0fc73ba3333ed4227659d6c2..b38edc67e71954671dfa2a6234ef68c3f33654cf 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

@@ -30,7 +30,7 @@ class ExtendedJitterReport : public RtcpPacket {

// Parse assumes header is already parsed and validated.

bool Parse(const CommonHeader& packet);

- bool WithJitter(uint32_t jitter);

+ bool SetJitters(std::vector<uint32_t> jitters);

sprang_webrtc 2016/09/16 15:37:33 nit: "jitters" is a somewhat overloaded word. Coul

danilchap 2016/09/16 16:27:49 how about jitter_value? (item feels too big for si

sprang_webrtc 2016/09/18 19:13:58 Sure!

const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }