Unify rtcp packet setters

webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 12 matching lines @@
 class ExtendedJitterReport : public RtcpPacket {
  public:
   static constexpr uint8_t kPacketType = 195;
 
   ExtendedJitterReport() {}
   ~ExtendedJitterReport() override {}
 
   // Parse assumes header is already parsed and validated.
   bool Parse(const CommonHeader& packet);
 
-  bool WithJitter(uint32_t jitter);
+  bool SetJitters(std::vector<uint32_t> jitters);

[sprang_webrtc, 2016/09/16 15:37:33]

nit: "jitters" is a somewhat overloaded word. Could we use "jitter items" or
something instead?

[danilchap, 2016/09/16 16:27:49]

how about jitter_value?
(item feels too big for single value, inter_arrival_jitter - too long)

[sprang_webrtc, 2016/09/18 19:13:58]

Sure!

 
   const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }
 
  protected:
   bool Create(uint8_t* packet,
               size_t* index,
               size_t max_length,
               RtcpPacket::PacketReadyCallback* callback) const override;
 
  private:
   static constexpr size_t kMaxNumberOfJitters = 0x1f;
   static constexpr size_t kJitterSizeBytes = 4;
 
   size_t BlockLength() const override {
     return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
   }
 
   std::vector<uint32_t> inter_arrival_jitters_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(ExtendedJitterReport);
 };
 
 }  // namespace rtcp
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_