Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
index c9e01aadd0dffc0d59c5d0fc3a184e752a2fdc2f..3772d9cfceb98425845640e84a638b277caf3a68 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc
@@ -36,7 +36,7 @@ TEST(RtcpPacketExtendedJitterReportTest, CreateAndParseWithoutItems) {
TEST(RtcpPacketExtendedJitterReportTest, CreateAndParseWithOneItem) {
ExtendedJitterReport ij;
- EXPECT_TRUE(ij.WithJitter(kJitter1));
+ EXPECT_TRUE(ij.SetJitters({kJitter1}));
rtc::Buffer raw = ij.Build();
ExtendedJitterReport parsed;
@@ -47,8 +47,7 @@ TEST(RtcpPacketExtendedJitterReportTest, CreateAndParseWithOneItem) {
TEST(RtcpPacketExtendedJitterReportTest, CreateAndParseWithTwoItems) {
ExtendedJitterReport ij;
- EXPECT_TRUE(ij.WithJitter(kJitter1));
- EXPECT_TRUE(ij.WithJitter(kJitter2));
+ EXPECT_TRUE(ij.SetJitters({kJitter1, kJitter2}));
rtc::Buffer raw = ij.Build();
ExtendedJitterReport parsed;
@@ -60,15 +59,13 @@ TEST(RtcpPacketExtendedJitterReportTest, CreateAndParseWithTwoItems) {
TEST(RtcpPacketExtendedJitterReportTest, CreateWithTooManyItems) {
ExtendedJitterReport ij;
const int kMaxIjItems = (1 << 5) - 1;
- for (int i = 0; i < kMaxIjItems; ++i) {
- EXPECT_TRUE(ij.WithJitter(i));
- }
- EXPECT_FALSE(ij.WithJitter(kMaxIjItems));
+ EXPECT_FALSE(ij.SetJitters(std::vector<uint32_t>(kMaxIjItems + 1, kJitter1)));
+ EXPECT_TRUE(ij.SetJitters(std::vector<uint32_t>(kMaxIjItems, kJitter1)));
}
TEST(RtcpPacketExtendedJitterReportTest, ParseFailsWithTooManyItems) {
ExtendedJitterReport ij;
- ij.WithJitter(kJitter1);
+ ij.SetJitters({kJitter1});
rtc::Buffer raw = ij.Build();
raw[0]++; // Damage packet: increase jitter count by 1.
ExtendedJitterReport parsed;

Powered by Google App Engine
This is Rietveld 408576698