Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
index a801816650c8f8bb0d9d42a941b14bbf46d338a6..23db484edf8d6d406df74158ac33c1d30cd1b086 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h
@@ -34,10 +34,7 @@ class Tmmbn : public Rtpfb {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void WithTmmbr(uint32_t ssrc, uint32_t bitrate_kbps, uint16_t overhead) {
- WithTmmbr(TmmbItem(ssrc, bitrate_kbps * 1000, overhead));
- }
- void WithTmmbr(const TmmbItem& item);
+ void AddTmmbr(const TmmbItem& item);
const std::vector<TmmbItem>& items() const { return items_; }
@@ -54,7 +51,7 @@ class Tmmbn : public Rtpfb {
}
// Media ssrc is unused, shadow base class setter and getter.
- void To(uint32_t ssrc);
+ void SetMediaSsrc(uint32_t ssrc);
uint32_t media_ssrc() const;
std::vector<TmmbItem> items_;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698