Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 class Tmmbn : public Rtpfb { 27 class Tmmbn : public Rtpfb {
28 public: 28 public:
29 static constexpr uint8_t kFeedbackMessageType = 4; 29 static constexpr uint8_t kFeedbackMessageType = 4;
30 30
31 Tmmbn() {} 31 Tmmbn() {}
32 ~Tmmbn() override {} 32 ~Tmmbn() override {}
33 33
34 // Parse assumes header is already parsed and validated. 34 // Parse assumes header is already parsed and validated.
35 bool Parse(const CommonHeader& packet); 35 bool Parse(const CommonHeader& packet);
36 36
37 void WithTmmbr(uint32_t ssrc, uint32_t bitrate_kbps, uint16_t overhead) { 37 void AddTmmbr(const TmmbItem& item);
38 WithTmmbr(TmmbItem(ssrc, bitrate_kbps * 1000, overhead));
39 }
40 void WithTmmbr(const TmmbItem& item);
41 38
42 const std::vector<TmmbItem>& items() const { return items_; } 39 const std::vector<TmmbItem>& items() const { return items_; }
43 40
44 protected: 41 protected:
45 bool Create(uint8_t* packet, 42 bool Create(uint8_t* packet,
46 size_t* index, 43 size_t* index,
47 size_t max_length, 44 size_t max_length,
48 RtcpPacket::PacketReadyCallback* callback) const override; 45 RtcpPacket::PacketReadyCallback* callback) const override;
49 46
50 private: 47 private:
51 size_t BlockLength() const override { 48 size_t BlockLength() const override {
52 return kHeaderLength + kCommonFeedbackLength + 49 return kHeaderLength + kCommonFeedbackLength +
53 TmmbItem::kLength * items_.size(); 50 TmmbItem::kLength * items_.size();
54 } 51 }
55 52
56 // Media ssrc is unused, shadow base class setter and getter. 53 // Media ssrc is unused, shadow base class setter and getter.
57 void To(uint32_t ssrc); 54 void SetMediaSsrc(uint32_t ssrc);
58 uint32_t media_ssrc() const; 55 uint32_t media_ssrc() const;
59 56
60 std::vector<TmmbItem> items_; 57 std::vector<TmmbItem> items_;
61 58
62 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbn); 59 RTC_DISALLOW_COPY_AND_ASSIGN(Tmmbn);
63 }; 60 };
64 } // namespace rtcp 61 } // namespace rtcp
65 } // namespace webrtc 62 } // namespace webrtc
66 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBN_H_ 63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TMMBN_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698