Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc

Issue 2348623003: Unify rtcp packet setters (Closed)
Patch Set: +call/rtc_event_log_unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
index dfb7d594b9edf5e933777e71fed12cfbf512654c..4b2fdea92b1a9e16c6444bab6117a6090dd32636 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc
@@ -42,9 +42,9 @@ constexpr uint8_t kPacket[] = {0x82, 206, 0x00, 0x03,
TEST(RtcpPacketSliTest, Create) {
Sli sli;
- sli.From(kSenderSsrc);
- sli.To(kRemoteSsrc);
- sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
+ sli.SetSenderSsrc(kSenderSsrc);
+ sli.SetMediaSsrc(kRemoteSsrc);
+ sli.AddPictureId(kPictureId, kFirstMb, kNumberOfMb);
rtc::Buffer packet = sli.Build();
@@ -67,9 +67,9 @@ TEST(RtcpPacketSliTest, Parse) {
TEST(RtcpPacketSliTest, ParseFailsOnTooSmallPacket) {
Sli sli;
- sli.From(kSenderSsrc);
- sli.To(kRemoteSsrc);
- sli.WithPictureId(kPictureId, kFirstMb, kNumberOfMb);
+ sli.SetSenderSsrc(kSenderSsrc);
+ sli.SetMediaSsrc(kRemoteSsrc);
+ sli.AddPictureId(kPictureId, kFirstMb, kNumberOfMb);
rtc::Buffer packet = sli.Build();
packet[3]--; // Decrease size by 1 word (4 bytes).
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698