AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
Committed: https://crrev.com/6b19b560ac2270bfd146b96bb9c2eab47a155339
Cr-Commit-Position: refs/heads/master@{#14304}

[kwiberg-webrtc, 2016-09-19 11:20:20]

Description was changed from

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
==========

to

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
==========

[kwiberg-webrtc, 2016-09-19 11:20:20]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-09-19 11:48:02]

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/audio_coding_module.cc (right):

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/audio_coding_module.cc:951: if
(receiver_initialized_)
Oooh, what's our policy on brackets for one-liners? Shouldn't they be there?

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decoder_database.h (right):

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decoder_database.h:140: void RemoveAll();
Add a unit test.

[kwiberg-webrtc, 2016-09-20 08:10:15]

New patch set uploaded.

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/audio_coding_module.cc (right):

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/audio_coding_module.cc:951: if
(receiver_initialized_)
On 2016/09/19 11:48:02, hlundin-webrtc wrote:
> Oooh, what's our policy on brackets for one-liners? Shouldn't they be there?

I think our policy is that either are fine if it's really a one-liner, and that
it's very good to stay consistent with the surrounding code.

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decoder_database.h (right):

https://codereview.webrtc.org/2348233002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decoder_database.h:140: void RemoveAll();
On 2016/09/19 11:48:02, hlundin-webrtc wrote:
> Add a unit test.

Done.

[hlundin-webrtc, 2016-09-20 08:46:53]

lgtm

[kwiberg-webrtc, 2016-09-20 10:43:00]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-09-20 10:43:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-20 11:02:33]

Description was changed from

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
==========

to

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
==========

[commit-bot: I haz the power, 2016-09-20 11:02:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 11:03:48]

Description was changed from

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801
==========

to

==========
AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

It requires a new NetEq method, but it can no longer fail. And we no
longer need to use AcmReceiver::decoders_, which we're trying to
eliminate.

(This is a re-land of https://codereview.webrtc.org/2342313002.)

BUG=webrtc:5801

Committed: https://crrev.com/6b19b560ac2270bfd146b96bb9c2eab47a155339
Cr-Commit-Position: refs/heads/master@{#14304}
==========

[commit-bot: I haz the power, 2016-09-20 11:04:19]

Patchset 3 (id:??) landed as
https://crrev.com/6b19b560ac2270bfd146b96bb9c2eab47a155339
Cr-Commit-Position: refs/heads/master@{#14304}