AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one

webrtc/modules/audio_coding/acm2/audio_coding_module.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 930 matching lines @@
 int AudioCodingModuleImpl::InitializeReceiver() {
   rtc::CritScope lock(&acm_crit_sect_);
   return InitializeReceiverSafe();
 }
 
 // Initialize receiver, resets codec database etc.
 int AudioCodingModuleImpl::InitializeReceiverSafe() {
   // If the receiver is already initialized then we want to destroy any
   // existing decoders. After a call to this function, we should have a clean
   // start-up.
-  if (receiver_initialized_) {
-    if (receiver_.RemoveAllCodecs() < 0)
-      return -1;
-  }
+  if (receiver_initialized_)

[hlundin-webrtc, 2016/09/19 11:48:02]

Oooh, what's our policy on brackets for one-liners? Shouldn't they be there?

[kwiberg-webrtc, 2016/09/20 08:10:15]

I think our policy is that either are fine if it's really a one-liner, and that
it's very good to stay consistent with the surrounding code.

+    receiver_.RemoveAllCodecs();
   receiver_.ResetInitialDelay();
   receiver_.SetMinimumDelay(0);
   receiver_.SetMaximumDelay(0);
   receiver_.FlushBuffers();
 
   // Register RED and CN.
   auto db = acm2::RentACodec::Database();
   for (size_t i = 0; i < db.size(); i++) {
     if (IsCodecRED(db[i]) || IsCodecCN(db[i])) {
       if (receiver_.AddCodec(static_cast<int>(i),
@@ skipping 392 matching lines @@
 // Checks the validity of the parameters of the given codec
 bool AudioCodingModule::IsCodecValid(const CodecInst& codec) {
   bool valid = acm2::RentACodec::IsCodecValid(codec);
   if (!valid)
     WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceAudioCoding, -1,
                  "Invalid codec setting");
   return valid;
 }
 
 }  // namespace webrtc