Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2354453003: AcmReceiver: Look up last decoder in NetEq's table of decoders (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AcmReceiver: Look up last decoder in NetEq's table of decoders AcmReceiver::decoders_ is now one step closer to being unused. (This is a re-land of https://codereview.webrtc.org/2339953002.) BUG=webrtc:5801 Committed: https://crrev.com/6f0f616b53c0a7b95f7616fdcafe67ec595b2b33 Cr-Commit-Position: refs/heads/master@{#14303}

Patch Set 1 #

Total comments: 10

Patch Set 2 : review comments #

Total comments: 2

Patch Set 3 : grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -69 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 6 chunks +27 lines, -53 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hlundin-webrtc
LG. Please, consider (at least a few of) my comments. https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right): https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc#newcode94 ...
4 years, 3 months ago (2016-09-19 11:37:36 UTC) #3
kwiberg-webrtc
New patch set posted. https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right): https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc#newcode94 webrtc/modules/audio_coding/acm2/acm_receiver.cc:94: if (last_audio_decoder_ && last_audio_decoder_->channels > ...
4 years, 3 months ago (2016-09-19 12:18:34 UTC) #4
hlundin-webrtc
LGTM with one nit. https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc File webrtc/modules/audio_coding/acm2/acm_receiver.cc (right): https://codereview.webrtc.org/2354453003/diff/1/webrtc/modules/audio_coding/acm2/acm_receiver.cc#newcode94 webrtc/modules/audio_coding/acm2/acm_receiver.cc:94: if (last_audio_decoder_ && last_audio_decoder_->channels > ...
4 years, 3 months ago (2016-09-19 12:22:03 UTC) #5
kwiberg-webrtc
https://codereview.webrtc.org/2354453003/diff/20001/webrtc/modules/audio_coding/neteq/include/neteq.h File webrtc/modules/audio_coding/neteq/include/neteq.h (right): https://codereview.webrtc.org/2354453003/diff/20001/webrtc/modules/audio_coding/neteq/include/neteq.h#newcode255 webrtc/modules/audio_coding/neteq/include/neteq.h:255: // Return info about the decoder for the given ...
4 years, 3 months ago (2016-09-20 08:15:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2354453003/40001
4 years, 3 months ago (2016-09-20 08:16:00 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-20 10:07:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 10:07:54 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f0f616b53c0a7b95f7616fdcafe67ec595b2b33
Cr-Commit-Position: refs/heads/master@{#14303}

Powered by Google App Engine
This is Rietveld 408576698