Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: webrtc/modules/video_coding/BUILD.gn

Issue 2347263002: GN: Enable rtc_common_config for more targets. (Closed)
Patch Set: GN: Enable rtc_common_config for more targets. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/sdk/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/BUILD.gn
diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
index 979355d22987abfafaea32973317628da4dee290..3db9b029ba506bab2e686bc46baa64ab240d7f31 100644
--- a/webrtc/modules/video_coding/BUILD.gn
+++ b/webrtc/modules/video_coding/BUILD.gn
@@ -169,6 +169,15 @@ rtc_source_set("webrtc_h264") {
}
if (is_ios) {
+ config("webrtc_h264_video_toolbox_warnings_config") {
+ if (is_clang) {
+ # TODO(tkchin): Make webrtc_h264_video_toolbox compile with the standard set
+ # of warnings.
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6307
+ cflags = [ "-Wno-thread-safety-analysis" ]
+ }
+ }
+
rtc_source_set("webrtc_h264_video_toolbox") {
sources = [
"codecs/h264/h264_video_toolbox_decoder.cc",
@@ -180,15 +189,11 @@ if (is_ios) {
]
configs += [
+ ":webrtc_h264_video_toolbox_warnings_config",
"../..:common_objc",
"//build/config/compiler:enable_arc",
]
- # TODO(hbos): Make webrtc_h264_video_toolbox compile with the standard set
- # of warnings.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6307
- suppressed_configs += [ rtc_common_config ]
-
deps = [
"../../sdk:rtc_sdk_common_objc",
]
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698