Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2347263002: GN: Enable rtc_common_config for more targets. (Closed)
Patch Set: GN: Enable rtc_common_config for more targets. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 3b99746ef4a76e18f41327c52cbec36be8d0ad09..70954eee8b5b4ed4d4f2abf32cd2e78c1b414f80 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -68,6 +68,15 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
}
}
+ config("rtc_sdk_peerconnection_objc_warnings_config") {
+ if (is_clang) {
+ # TODO(tkchin): Make rtc_sdk_peerconnection_objc compile with the standard
+ # set of warnings.
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6308
+ cflags = [ "-Wno-thread-safety-analysis" ]
+ }
+ }
+
rtc_source_set("rtc_sdk_peerconnection_objc") {
sources = [
"objc/Framework/Classes/RTCAVFoundationVideoSource+Private.h",
@@ -185,15 +194,11 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
}
configs += [
+ ":rtc_sdk_peerconnection_objc_warnings_config",
"..:common_objc",
"//build/config/compiler:enable_arc",
]
- # TODO(tkchin): Make rtc_sdk_peerconnection_objc compile with the standard
- # set of warnings.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6308
- suppressed_configs += [ rtc_common_config ]
-
public_configs = [ ":rtc_sdk_common_objc_config" ]
if (is_clang) {
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698