Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: webrtc/examples/BUILD.gn

Issue 2347263002: GN: Enable rtc_common_config for more targets. (Closed)
Patch Set: GN: Enable rtc_common_config for more targets. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index d05a0c79fdb803a70564e61cfd11ee6542c95f79..4ebfeaffcb621a7ffdcf0654501473567601c99e 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -377,8 +377,9 @@ if (is_linux || is_win) {
}
config("peerconnection_client_warnings_config") {
+ cflags = []
if (is_win && is_clang) {
- cflags = [
+ cflags += [
# Disable warnings failing when compiling with Clang on Windows.
# https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
"-Wno-format",
@@ -390,11 +391,18 @@ if (is_linux || is_win) {
]
}
if (is_linux && target_cpu == "x86") {
- cflags = [
+ cflags += [
# Needed to compile on Linux 32-bit.
"-Wno-sentinel",
]
}
+
+ if (is_clang) {
+ # TODO(ehmaldonado): Make peerconnection_client compile with the standard
+ # set of warnings.
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6306
+ cflags += [ "-Wno-inconsistent-missing-override" ]
+ }
}
rtc_executable("peerconnection_client") {
@@ -407,10 +415,6 @@ if (is_linux || is_win) {
"peerconnection/client/peer_connection_client.h",
]
- # TODO(ehmaldonado): Make peerconnection_client compile with the standard
- # set of warnings.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6306
- suppressed_configs += [ rtc_common_config ]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
« no previous file with comments | « no previous file | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698