Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2347263002: GN: Enable rtc_common_config for more targets. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Enable rtc_common_config for more targets. In the migration to GN templates, some targets got the whole rtc_common_config removed, which can have unpredicted consequences in terms of different code behavior due to defines not being set as expected etc. It's better to enable this config and only disable the warnings that fails the build. BUG=webrtc:6306, webrtc:6307, webrtc:6308 NOTRY=True Committed: https://crrev.com/4a9abad208cbde5b55e515f584e374ea939b2eea Cr-Commit-Position: refs/heads/master@{#14280}

Patch Set 1 #

Patch Set 2 : GN: Enable rtc_common_config for more targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M webrtc/examples/BUILD.gn View 1 3 chunks +10 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 chunks +10 lines, -5 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-17 07:45:26 UTC) #2
ehmaldonado_webrtc
On 2016/09/17 07:45:26, kjellander_webrtc wrote: Yeah, much better :) LGTM
4 years, 3 months ago (2016-09-17 07:52:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2347263002/20001
4 years, 3 months ago (2016-09-18 15:04:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-18 15:12:32 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-18 15:12:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a9abad208cbde5b55e515f584e374ea939b2eea
Cr-Commit-Position: refs/heads/master@{#14280}

Powered by Google App Engine
This is Rietveld 408576698