Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2340443002: Making sure rtc_stats_unittests passes on all bots (tsan fix) (Closed)

Created:
4 years, 3 months ago by hbos
Modified:
4 years, 3 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making sure rtc_stats_unittests passes on all bots (tsan fix) NOCOMMIT=True

Patch Set 1 : Move all webrtc/stats/ unittests to a target that is run on the bots (libjingle_peerconnection) #

Patch Set 2 : Fix race #

Patch Set 3 : String compare fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -756 lines) Patch
M webrtc/api/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/api_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + webrtc/api/rtcstats_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
A + webrtc/api/rtcstatscollector_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/api/rtcstatsreport_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/stats/BUILD.gn View 1 chunk +1 line, -31 lines 0 comments Download
D webrtc/stats/rtcstats_unittest.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D webrtc/stats/rtcstatscollector_unittest.cc View 1 chunk +0 lines, -383 lines 0 comments Download
D webrtc/stats/rtcstatsreport_unittest.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M webrtc/stats/stats.gyp View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
hbos
Patchset #2 (id:20001) has been deleted
4 years, 3 months ago (2016-09-13 15:22:27 UTC) #1
hbos
The CQ bit was checked by hbos@webrtc.org to run a CQ dry run
4 years, 3 months ago (2016-09-14 07:19:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340443002/40001
4 years, 3 months ago (2016-09-14 07:19:17 UTC) #3
hbos
The CQ bit was checked by hbos@webrtc.org to run a CQ dry run
4 years, 3 months ago (2016-09-14 07:33:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340443002/60001
4 years, 3 months ago (2016-09-14 07:34:05 UTC) #5
hbos
Description was changed from ========== Making sure rtc_stats_unittests passes on all bots (tsan fix) BUG= ...
4 years, 3 months ago (2016-09-14 07:41:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-14 09:34:28 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 09:34:32 UTC) #8 
Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

Powered by Google App Engine
This is Rietveld 408576698