Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: webrtc/stats/rtcstats_unittest.cc

Issue 2340443002: Making sure rtc_stats_unittests passes on all bots (tsan fix) (Closed)
Patch Set: String compare fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/stats/BUILD.gn ('k') | webrtc/stats/rtcstatscollector_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/api/rtcstats.h"
12
13 #include "webrtc/base/checks.h"
14 #include "webrtc/base/gunit.h"
15
16 namespace webrtc {
17
18 class RTCTestStats : public RTCStats {
19 public:
20 RTCTestStats(const std::string& id, int64_t timestamp_us)
21 : RTCStats(id, timestamp_us),
22 m_int32("mInt32"),
23 m_uint32("mUint32"),
24 m_int64("mInt64"),
25 m_uint64("mUint64"),
26 m_double("mDouble"),
27 m_static_string("mStaticString"),
28 m_string("mString"),
29 m_sequence_int32("mSequenceInt32"),
30 m_sequence_uint32("mSequenceUint32"),
31 m_sequence_int64("mSequenceInt64"),
32 m_sequence_uint64("mSequenceUint64"),
33 m_sequence_double("mSequenceDouble"),
34 m_sequence_static_string("mSequenceStaticString"),
35 m_sequence_string("mSequenceString") {
36 }
37
38 WEBRTC_RTCSTATS_IMPL(RTCStats, RTCTestStats,
39 &m_int32,
40 &m_uint32,
41 &m_int64,
42 &m_uint64,
43 &m_double,
44 &m_static_string,
45 &m_string,
46 &m_sequence_int32,
47 &m_sequence_uint32,
48 &m_sequence_int64,
49 &m_sequence_uint64,
50 &m_sequence_double,
51 &m_sequence_static_string,
52 &m_sequence_string);
53
54 RTCStatsMember<int32_t> m_int32;
55 RTCStatsMember<uint32_t> m_uint32;
56 RTCStatsMember<int64_t> m_int64;
57 RTCStatsMember<uint64_t> m_uint64;
58 RTCStatsMember<double> m_double;
59 RTCStatsMember<const char*> m_static_string;
60 RTCStatsMember<std::string> m_string;
61
62 RTCStatsMember<std::vector<int32_t>> m_sequence_int32;
63 RTCStatsMember<std::vector<uint32_t>> m_sequence_uint32;
64 RTCStatsMember<std::vector<int64_t>> m_sequence_int64;
65 RTCStatsMember<std::vector<uint64_t>> m_sequence_uint64;
66 RTCStatsMember<std::vector<double>> m_sequence_double;
67 RTCStatsMember<std::vector<const char*>> m_sequence_static_string;
68 RTCStatsMember<std::vector<std::string>> m_sequence_string;
69 };
70
71 const char RTCTestStats::kType[] = "test-stats";
72
73 class RTCChildStats : public RTCStats {
74 public:
75 RTCChildStats(const std::string& id, int64_t timestamp_us)
76 : RTCStats(id, timestamp_us),
77 child_int("childInt") {}
78
79 WEBRTC_RTCSTATS_IMPL(RTCStats, RTCChildStats,
80 &child_int);
81
82 RTCStatsMember<int32_t> child_int;
83 };
84
85 const char RTCChildStats::kType[] = "child-stats";
86
87 class RTCGrandChildStats : public RTCChildStats {
88 public:
89 RTCGrandChildStats(const std::string& id, int64_t timestamp_us)
90 : RTCChildStats(id, timestamp_us),
91 grandchild_int("grandchildInt") {}
92
93 WEBRTC_RTCSTATS_IMPL(RTCChildStats, RTCGrandChildStats,
94 &grandchild_int);
95
96 RTCStatsMember<int32_t> grandchild_int;
97 };
98
99 const char RTCGrandChildStats::kType[] = "grandchild-stats";
100
101 TEST(RTCStatsTest, RTCStatsAndMembers) {
102 RTCTestStats stats("testId", 42);
103 EXPECT_EQ(stats.id(), "testId");
104 EXPECT_EQ(stats.timestamp_us(), static_cast<int64_t>(42));
105 std::vector<const RTCStatsMemberInterface*> members = stats.Members();
106 EXPECT_EQ(members.size(), static_cast<size_t>(14));
107 for (const RTCStatsMemberInterface* member : members) {
108 EXPECT_FALSE(member->is_defined());
109 }
110 stats.m_int32 = 123;
111 stats.m_uint32 = 123;
112 stats.m_int64 = 123;
113 stats.m_uint64 = 123;
114 stats.m_double = 123.0;
115 stats.m_static_string = "123";
116 stats.m_string = std::string("123");
117 stats.m_sequence_int32 = std::vector<int32_t>();
118 stats.m_sequence_uint32 = std::vector<uint32_t>();
119 EXPECT_FALSE(stats.m_sequence_int64.is_defined());
120 stats.m_sequence_int64 = std::vector<int64_t>();
121 stats.m_sequence_uint64 = std::vector<uint64_t>();
122 stats.m_sequence_double = std::vector<double>();
123 stats.m_sequence_static_string = std::vector<const char*>();
124 stats.m_sequence_string = std::vector<std::string>();
125 for (const RTCStatsMemberInterface* member : members) {
126 EXPECT_TRUE(member->is_defined());
127 }
128 EXPECT_EQ(*stats.m_int32, static_cast<int32_t>(123));
129 EXPECT_EQ(*stats.m_uint32, static_cast<uint32_t>(123));
130 EXPECT_EQ(*stats.m_int64, static_cast<int64_t>(123));
131 EXPECT_EQ(*stats.m_uint64, static_cast<uint64_t>(123));
132 EXPECT_EQ(*stats.m_double, 123.0);
133 EXPECT_EQ(*stats.m_static_string, "123");
134 EXPECT_EQ(*stats.m_string, std::string("123"));
135 EXPECT_EQ(*stats.m_sequence_int32, std::vector<int32_t>());
136 EXPECT_EQ(*stats.m_sequence_uint32, std::vector<uint32_t>());
137 EXPECT_EQ(*stats.m_sequence_int64, std::vector<int64_t>());
138 EXPECT_EQ(*stats.m_sequence_uint64, std::vector<uint64_t>());
139 EXPECT_EQ(*stats.m_sequence_double, std::vector<double>());
140 EXPECT_EQ(*stats.m_sequence_static_string, std::vector<const char*>());
141 EXPECT_EQ(*stats.m_sequence_string, std::vector<std::string>());
142 int32_t numbers[] = { 4, 8, 15, 16, 23, 42 };
143 std::vector<int32_t> numbers_sequence(&numbers[0], &numbers[5]);
144 stats.m_sequence_int32->insert(stats.m_sequence_int32->end(),
145 numbers_sequence.begin(),
146 numbers_sequence.end());
147 EXPECT_EQ(*stats.m_sequence_int32, numbers_sequence);
148 }
149
150 TEST(RTCStatsTest, RTCStatsGrandChild) {
151 RTCGrandChildStats stats("grandchild", 0.0);
152 stats.child_int = 1;
153 stats.grandchild_int = 2;
154 int32_t sum = 0;
155 for (const RTCStatsMemberInterface* member : stats.Members()) {
156 sum += *member->cast_to<const RTCStatsMember<int32_t>>();
157 }
158 EXPECT_EQ(sum, static_cast<int32_t>(3));
159
160 std::unique_ptr<RTCStats> copy_ptr = stats.copy();
161 const RTCGrandChildStats& copy = copy_ptr->cast_to<RTCGrandChildStats>();
162 EXPECT_EQ(*copy.child_int, *stats.child_int);
163 EXPECT_EQ(*copy.grandchild_int, *stats.grandchild_int);
164 }
165
166 // Death tests.
167 // Disabled on Android because death tests misbehave on Android, see
168 // base/test/gtest_util.h.
169 #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
170
171 TEST(RTCStatsDeathTest, ValueOfUndefinedMember) {
172 RTCTestStats stats("testId", 0.0);
173 EXPECT_FALSE(stats.m_int32.is_defined());
174 EXPECT_DEATH(*stats.m_int32, "");
175 }
176
177 TEST(RTCStatsDeathTest, InvalidCasting) {
178 RTCGrandChildStats stats("grandchild", 0.0);
179 EXPECT_DEATH(stats.cast_to<RTCChildStats>(), "");
180 }
181
182 #endif // RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
183
184 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/stats/BUILD.gn ('k') | webrtc/stats/rtcstatscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698