Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: webrtc/api/rtcstats_unittest.cc

Issue 2340443002: Making sure rtc_stats_unittests passes on all bots (tsan fix) (Closed)
Patch Set: String compare fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/rtcstatscollector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstats_unittest.cc
diff --git a/webrtc/stats/rtcstats_unittest.cc b/webrtc/api/rtcstats_unittest.cc
similarity index 98%
rename from webrtc/stats/rtcstats_unittest.cc
rename to webrtc/api/rtcstats_unittest.cc
index 1d4e016044dc77dadb55af5f4f1289208629cb8b..2908deba607615aa9483651d92ef4f23c279678d 100644
--- a/webrtc/stats/rtcstats_unittest.cc
+++ b/webrtc/api/rtcstats_unittest.cc
@@ -10,6 +10,8 @@
#include "webrtc/api/rtcstats.h"
+#include <cstring>
+
#include "webrtc/base/checks.h"
#include "webrtc/base/gunit.h"
@@ -130,7 +132,7 @@ TEST(RTCStatsTest, RTCStatsAndMembers) {
EXPECT_EQ(*stats.m_int64, static_cast<int64_t>(123));
EXPECT_EQ(*stats.m_uint64, static_cast<uint64_t>(123));
EXPECT_EQ(*stats.m_double, 123.0);
- EXPECT_EQ(*stats.m_static_string, "123");
+ EXPECT_EQ(strcmp(*stats.m_static_string, "123"), 0);
EXPECT_EQ(*stats.m_string, std::string("123"));
EXPECT_EQ(*stats.m_sequence_int32, std::vector<int32_t>());
EXPECT_EQ(*stats.m_sequence_uint32, std::vector<uint32_t>());
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/rtcstatscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698