Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2332213011: Reland of Optimize Android NV12 capture (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Optimize Android NV12 capture (patchset #1 id:1 of https://codereview.webrtc.org/2327893002/ ) Reason for revert: Import breakage has been fixed. Original issue's description: > Revert of Optimize Android NV12 capture (patchset #2 id:20001 of https://codereview.webrtc.org/2317443003/ ) > > Reason for revert: > Import breakage in g3. > > Original issue's description: > > Optimize Android NV12 capture > > > > This CL optimizes the Android capture NV12 -> I420 + scaling code. For > > example, when the input is 1280x720 and we adapt to 640x360, this CL: > > - Reduces conversion time from 3.37 ms to 1.46 ms. > > - Reduces memory footprint by 1 MB. > > > > BUG=webrtc:6319 > > > > Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2 > > Cr-Commit-Position: refs/heads/master@{#14167} > > TBR=sakal@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6319 TBR=sakal@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6319 Committed: https://crrev.com/1a7ef1f025aa770b38c751e7453727d5758b6d56 Cr-Commit-Position: refs/heads/master@{#14273}

Patch Set 1 #

Patch Set 2 : Rebase and make helper class instead #

Patch Set 3 : Fix dst vs src width/height bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -29 lines) Patch
M webrtc/api/androidvideotracksource.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/androidvideotracksource.cc View 1 2 chunks +37 lines, -26 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
magjed_webrtc
Created Revert of Revert "Optimize Android NV12 capture"
4 years, 3 months ago (2016-09-16 07:35:36 UTC) #1
magjed_webrtc
Sami - please take a look. This is a reland, but I refactored it slightly ...
4 years, 3 months ago (2016-09-16 08:23:37 UTC) #7
sakal
lgtm
4 years, 3 months ago (2016-09-16 08:34:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213011/140001
4 years, 3 months ago (2016-09-16 09:01:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-16 11:01:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213011/160001
4 years, 3 months ago (2016-09-16 12:40:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14414) mac_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 12:42:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213011/160001
4 years, 3 months ago (2016-09-16 13:47:52 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-16 14:41:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2332213011/160001
4 years, 3 months ago (2016-09-17 09:26:59 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:160001)
4 years, 3 months ago (2016-09-17 09:39:06 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 09:39:15 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a7ef1f025aa770b38c751e7453727d5758b6d56
Cr-Commit-Position: refs/heads/master@{#14273}

Powered by Google App Engine
This is Rietveld 408576698