Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2324963003: Store custom properties specified in element.animate() (Closed)

Created:
4 years, 3 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store custom properties specified in element.animate() This change alters calls to element.animate() that use custom properties such that the custom property values are stored internally in animation keyframes. This patch has no behavioural changes as custom property animations are currently not applied (see bug). This patch is a step towards enabling custom property animations. BUG=644148 Committed: https://crrev.com/16207749c729ef2dcf5270702eb6318226c704ab Cr-Commit-Position: refs/heads/master@{#422041}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Add unit tests and use existing parser logic #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-09-29 10:29:20 UTC) #3
Eric Willigers
lgtm
4 years, 2 months ago (2016-09-29 22:20:40 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2309873003 Patch 80001). Please resolve the dependency and ...
4 years, 2 months ago (2016-09-29 22:21:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324963003/60001
4 years, 2 months ago (2016-09-30 04:34:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/78155)
4 years, 2 months ago (2016-09-30 04:36:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324963003/80001
4 years, 2 months ago (2016-09-30 04:44:39 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-30 06:16:16 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 06:18:30 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/16207749c729ef2dcf5270702eb6318226c704ab
Cr-Commit-Position: refs/heads/master@{#422041}

Powered by Google App Engine
This is Rietveld 408576698