third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp - Issue 2324963003: Store custom properties specified in element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

Issue 2324963003: Store custom properties specified in element.animate() (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

index cc1fa760333970dbbe233954330ce59d3f86bb65..24c39274315141013a96dbc115478ebc0a5d01f1 100644

--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp

@@ -69,7 +69,13 @@ TEST_F(AnimationAnimationInputHelpersTest, ParseKeyframePropertyAttributes)

EXPECT_EQ(CSSPropertyWidth, keyframeAttributeToCSSProperty("width"));

EXPECT_EQ(CSSPropertyFloat, keyframeAttributeToCSSProperty("float"));

EXPECT_EQ(CSSPropertyFloat, keyframeAttributeToCSSProperty("cssFloat"));

+ EXPECT_EQ(CSSPropertyVariable, keyframeAttributeToCSSProperty("--"));

+ EXPECT_EQ(CSSPropertyVariable, keyframeAttributeToCSSProperty("---"));

+ EXPECT_EQ(CSSPropertyVariable, keyframeAttributeToCSSProperty("--x"));

+ EXPECT_EQ(CSSPropertyVariable, keyframeAttributeToCSSProperty("--webkit-custom-property"));

+ EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty(""));

+ EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("-"));

EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("line-height"));

EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("border-topWidth"));

EXPECT_EQ(CSSPropertyInvalid, keyframeAttributeToCSSProperty("Width"));