Optimize Android NV12 capture

Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2
Cr-Commit-Position: refs/heads/master@{#14167}

[magjed_webrtc, 2016-09-06 14:31:23]

Description was changed from

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
==========

to

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
==========

[magjed_webrtc, 2016-09-06 14:31:23]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-09-06 14:31:33]

Sami - please take a look.

[sakal, 2016-09-07 10:07:58]

lgtm

https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/in...
File webrtc/common_video/libyuv/include/webrtc_libyuv.h (right):

https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/in...
webrtc/common_video/libyuv/include/webrtc_libyuv.h:128: // separate U and V
planes, and the size of that memory region must be enough
nit: Comment on how much is "enough for that purpose".

[magjed_webrtc, 2016-09-08 11:57:25]

https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/in...
File webrtc/common_video/libyuv/include/webrtc_libyuv.h (right):

https://codereview.webrtc.org/2317443003/diff/1/webrtc/common_video/libyuv/in...
webrtc/common_video/libyuv/include/webrtc_libyuv.h:128: // separate U and V
planes, and the size of that memory region must be enough
On 2016/09/07 10:07:58, sakal wrote:
> nit: Comment on how much is "enough for that purpose".

Done.

[magjed_webrtc, 2016-09-08 11:57:28]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-09-08 11:57:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2317443003/#ps20001 (title:
"Update memory region comment")

[commit-bot: I haz the power, 2016-09-08 11:57:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 12:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 12:01:33]

Try jobs failed on following builders:
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/16621)

[magjed_webrtc, 2016-09-09 15:27:14]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-09-09 15:27:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-09 16:09:51]

Description was changed from

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
==========

to

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
==========

[commit-bot: I haz the power, 2016-09-09 16:09:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 16:09:55]

Description was changed from

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319
==========

to

==========
Optimize Android NV12 capture

This CL optimizes the Android capture NV12 -> I420 + scaling code. For
example, when the input is 1280x720 and we adapt to 640x360, this CL:
 - Reduces conversion time from 3.37 ms to 1.46 ms.
 - Reduces memory footprint by 1 MB.

BUG=webrtc:6319

Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2
Cr-Commit-Position: refs/heads/master@{#14167}
==========

[commit-bot: I haz the power, 2016-09-09 16:09:56]

Patchset 2 (id:??) landed as
https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2
Cr-Commit-Position: refs/heads/master@{#14167}

[magjed_webrtc, 2016-09-16 07:36:39]

On 2016/09/09 16:09:56, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2
> Cr-Commit-Position: refs/heads/master@{#14167}

This CL was reverted here: https://codereview.webrtc.org/2327893002.

[magjed_webrtc, 2016-09-16 07:37:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2349663002/ by magjed@webrtc.org.

The reason for reverting is: Import breakage in g3..