Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2314743002: Centralize deactivation of Unequal Protection. (Closed)

Created:
4 years, 3 months ago by brandtr
Modified:
4 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Centralize deactivation of Unequal Protection. This CL introduces changes that clearly demarcate where we disable Unequal Protection in the FEC. No functional changes are expected. BUG=webrtc:5654 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/3821399075cb7377f828e0259eba60a7d585e0be

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Patch Set 7 : Fix fuzzer here too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M webrtc/modules/rtp_rtcp/source/producer_fec.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec.cc View 1 2 3 chunks +4 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 2 3 4 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/test/fuzzers/producer_fec_fuzzer.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
brandtr
4 years, 3 months ago (2016-09-06 11:36:30 UTC) #2
brandtr
Rebase.
4 years, 3 months ago (2016-09-06 14:37:56 UTC) #3
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-13 08:07:41 UTC) #4
brandtr
Rebase.
4 years, 2 months ago (2016-09-27 08:23:19 UTC) #5
brandtr
Rebase.
4 years, 2 months ago (2016-10-03 12:10:09 UTC) #6
brandtr
Rebase.
4 years, 2 months ago (2016-10-04 07:13:04 UTC) #11
brandtr
Rebase.
4 years, 2 months ago (2016-10-04 07:18:12 UTC) #12
brandtr
Fix fuzzer here too.
4 years, 2 months ago (2016-10-04 08:52:12 UTC) #17
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/3821399075cb7377f828e0259eba60a7d585e0be Cr-Commit-Position: refs/heads/master@{#14496}
4 years, 2 months ago (2016-10-04 12:28:09 UTC) #20
brandtr
4 years, 2 months ago (2016-10-04 12:28:10 UTC) #21
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
3821399075cb7377f828e0259eba60a7d585e0be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698