Rename FecConfig to UlpfecConfig in config.h.

Rename FecConfig to UlpfecConfig in config.h.

Also rename some related minor methods. No functional changes
are intended/expected.

BUG=webrtc:5654
Committed: https://crrev.com/b5f2c3fbe92ef3f75c5aff287887505b04d0ce63
Cr-Commit-Position: refs/heads/master@{#14513}

[brandtr, 2016-10-04 10:18:53]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[brandtr, 2016-10-04 10:18:53]

Per our offline discussion a couple of weeks ago.

[stefan-webrtc, 2016-10-04 10:23:30]

lgtm % nit

https://codereview.webrtc.org/2391963002/diff/1/webrtc/config.h
File webrtc/config.h (right):

https://codereview.webrtc.org/2391963002/diff/1/webrtc/config.h#newcode47
webrtc/config.h:47: int ulpfec_payload_type;
Perhaps just call this payload_type?

[stefan-webrtc, 2016-10-04 10:24:36]

Maybe we should send out a PSA to discuss-webrtc though since this touches
higher level APIs?

[brandtr, 2016-10-04 10:44:23]

Yes, that might be a good idea.

For this simple renaming change, what do you think about landing the CL 1 week
after the PSA has been posted to discuss-webrtc and other relevant e-mail lists?
(This is what is suggested by the PRESUBMIT script.)

Your suggestion to rename 'ulpfec_payload_type' to 'payload_type' makes this CL
a little bit more complicated however. Perhaps better to skip that, to make the
PSA simpler and the required changes smaller?

[stefan-webrtc, 2016-10-04 10:51:28]

On 2016/10/04 10:44:23, brandtr wrote:
> Yes, that might be a good idea.
> 
> For this simple renaming change, what do you think about landing the CL 1 week
> after the PSA has been posted to discuss-webrtc and other relevant e-mail
lists?
> (This is what is suggested by the PRESUBMIT script.)

I'm fine with landing immediately after the PSA has been sent. Shouldn't be too
much work for users to update their code in this case.

> 
> Your suggestion to rename 'ulpfec_payload_type' to 'payload_type' makes this
CL
> a little bit more complicated however. Perhaps better to skip that, to make
the
> PSA simpler and the required changes smaller?

Sounds good.

[brandtr, 2016-10-04 10:54:44]

On 2016/10/04 10:51:28, stefan-webrtc (holmer) wrote:
> On 2016/10/04 10:44:23, brandtr wrote:
> > Yes, that might be a good idea.
> > 
> > For this simple renaming change, what do you think about landing the CL 1
week
> > after the PSA has been posted to discuss-webrtc and other relevant e-mail
> lists?
> > (This is what is suggested by the PRESUBMIT script.)
> 
> I'm fine with landing immediately after the PSA has been sent. Shouldn't be
too
> much work for users to update their code in this case.

Ok, sounds good! Will probably land tomorrow.

> 
> > 
> > Your suggestion to rename 'ulpfec_payload_type' to 'payload_type' makes this
> CL
> > a little bit more complicated however. Perhaps better to skip that, to make
> the
> > PSA simpler and the required changes smaller?
> 
> Sounds good.

[brandtr, 2016-10-04 10:54:57]

Patchset #2 (id:20001) has been deleted

[brandtr, 2016-10-04 13:37:27]

Rebase.

[brandtr, 2016-10-05 05:42:14]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-05 05:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2391963002/#ps40001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-10-05 05:42:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 06:28:42]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-05 06:28:49]

Description was changed from

==========
Rename FecConfig to UlpfecConfig in config.h.

Also rename some related minor methods. No functional changes
are intended/expected.

BUG=webrtc:5654
==========

to

==========
Rename FecConfig to UlpfecConfig in config.h.

Also rename some related minor methods. No functional changes
are intended/expected.

BUG=webrtc:5654

Committed: https://crrev.com/b5f2c3fbe92ef3f75c5aff287887505b04d0ce63
Cr-Commit-Position: refs/heads/master@{#14513}
==========

[commit-bot: I haz the power, 2016-10-05 06:28:50]

Patchset 2 (id:??) landed as
https://crrev.com/b5f2c3fbe92ef3f75c5aff287887505b04d0ce63
Cr-Commit-Position: refs/heads/master@{#14513}