Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2391963002: Rename FecConfig to UlpfecConfig in config.h. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_receive_stream.cc ('k') | webrtc/video/video_send_stream_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 3ff85d4f639ccca0e67e687f0b21acaa8220d541..2ba5c890a2e2171f942dc9037159a27ec4c49a9b 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -132,7 +132,7 @@ std::string VideoSendStream::Config::Rtp::ToString() const {
ss << ']';
ss << ", nack: {rtp_history_ms: " << nack.rtp_history_ms << '}';
- ss << ", fec: " << fec.ToString();
+ ss << ", ulpfec: " << ulpfec.ToString();
ss << ", rtx: " << rtx.ToString();
ss << ", c_name: " << c_name;
ss << '}';
@@ -922,7 +922,7 @@ void VideoSendStreamImpl::ConfigureProtection() {
RTC_DCHECK_RUN_ON(worker_queue_);
// Enable NACK, FEC or both.
const bool enable_protection_nack = config_->rtp.nack.rtp_history_ms > 0;
- bool enable_protection_fec = config_->rtp.fec.ulpfec_payload_type != -1;
+ bool enable_protection_fec = config_->rtp.ulpfec.ulpfec_payload_type != -1;
// Payload types without picture ID cannot determine that a stream is complete
// without retransmitting FEC, so using FEC + NACK for H.264 (for instance) is
// a waste of bandwidth since FEC packets still have to be transmitted. Note
@@ -943,21 +943,22 @@ void VideoSendStreamImpl::ConfigureProtection() {
// TODO(changbin): Should set RTX for RED mapping in RTP sender in future.
// Validate payload types. If either RED or FEC payload types are set then
// both should be. If FEC is enabled then they both have to be set.
- if (config_->rtp.fec.red_payload_type != -1) {
- RTC_DCHECK_GE(config_->rtp.fec.red_payload_type, 0);
- RTC_DCHECK_LE(config_->rtp.fec.red_payload_type, 127);
+ if (config_->rtp.ulpfec.red_payload_type != -1) {
+ RTC_DCHECK_GE(config_->rtp.ulpfec.red_payload_type, 0);
+ RTC_DCHECK_LE(config_->rtp.ulpfec.red_payload_type, 127);
// TODO(holmer): We should only enable red if ulpfec is also enabled, but
// but due to an incompatibility issue with previous versions the receiver
// assumes rtx packets are containing red if it has been configured to
// receive red. Remove this in a few versions once the incompatibility
// issue is resolved (M53 timeframe).
- payload_type_red = static_cast<uint8_t>(config_->rtp.fec.red_payload_type);
+ payload_type_red =
+ static_cast<uint8_t>(config_->rtp.ulpfec.red_payload_type);
}
- if (config_->rtp.fec.ulpfec_payload_type != -1) {
- RTC_DCHECK_GE(config_->rtp.fec.ulpfec_payload_type, 0);
- RTC_DCHECK_LE(config_->rtp.fec.ulpfec_payload_type, 127);
+ if (config_->rtp.ulpfec.ulpfec_payload_type != -1) {
+ RTC_DCHECK_GE(config_->rtp.ulpfec.ulpfec_payload_type, 0);
+ RTC_DCHECK_LE(config_->rtp.ulpfec.ulpfec_payload_type, 127);
payload_type_fec =
- static_cast<uint8_t>(config_->rtp.fec.ulpfec_payload_type);
+ static_cast<uint8_t>(config_->rtp.ulpfec.ulpfec_payload_type);
}
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
@@ -1012,11 +1013,11 @@ void VideoSendStreamImpl::ConfigureSsrcs() {
config_->encoder_settings.payload_type);
rtp_rtcp->SetRtxSendStatus(kRtxRetransmitted | kRtxRedundantPayloads);
}
- if (config_->rtp.fec.red_payload_type != -1 &&
- config_->rtp.fec.red_rtx_payload_type != -1) {
+ if (config_->rtp.ulpfec.red_payload_type != -1 &&
+ config_->rtp.ulpfec.red_rtx_payload_type != -1) {
for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
- rtp_rtcp->SetRtxSendPayloadType(config_->rtp.fec.red_rtx_payload_type,
- config_->rtp.fec.red_payload_type);
+ rtp_rtcp->SetRtxSendPayloadType(config_->rtp.ulpfec.red_rtx_payload_type,
+ config_->rtp.ulpfec.red_payload_type);
}
}
}
« no previous file with comments | « webrtc/video/video_receive_stream.cc ('k') | webrtc/video/video_send_stream_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698