Simplify public interface of ProducerFec.

Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
R=stefan@webrtc.org

Committed: https://crrev.com/c07ebb30c530888dc56a6d70cd5537336fdf12c2
Cr-Commit-Position: refs/heads/master@{#14491}

[brandtr, 2016-09-02 14:42:02]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[brandtr, 2016-09-02 14:42:03]

Please take a look :)

[brandtr, 2016-09-05 14:34:26]

Patchset #2 (id:20001) has been deleted

[stefan-webrtc, 2016-09-05 14:50:20]

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec.cc (left):

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec.cc:212: return
generated_fec_packets_.size();
Since generated_fec_packets_ is a list, this method may run in linear time
compared to the one you removed which is constant. Maybe it's worth keeping it?
Or remove NumAvailableFecPackets instead?

[stefan-webrtc, 2016-09-05 14:52:36]

lgtm

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec.cc (left):

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec.cc:212: return
generated_fec_packets_.size();
On 2016/09/05 14:50:20, stefan-webrtc (holmer) wrote:
> Since generated_fec_packets_ is a list, this method may run in linear time
> compared to the one you removed which is constant. Maybe it's worth keeping
it?
> Or remove NumAvailableFecPackets instead?

Or actually since it's only tests, I'm ok with doing as you've done.

[brandtr, 2016-09-05 14:58:38]

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec.cc (left):

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec.cc:212: return
generated_fec_packets_.size();
On 2016/09/05 14:52:36, stefan-webrtc (holmer) wrote:
> On 2016/09/05 14:50:20, stefan-webrtc (holmer) wrote:
> > Since generated_fec_packets_ is a list, this method may run in linear time
> > compared to the one you removed which is constant. Maybe it's worth keeping
> it?
> > Or remove NumAvailableFecPackets instead?
> 
> Or actually since it's only tests, I'm ok with doing as you've done.

NumAvailableFecPackets() is used by RTPSenderVideo to allocate sequence numbers
for the RED packets, so that's needed. I'll remove FecAvailable() :)

[brandtr, 2016-09-06 11:23:19]

Rebase.

[brandtr, 2016-09-06 14:37:43]

Rebase.

[brandtr, 2016-09-08 08:40:47]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Remove FecAvailable(). This member function is only used
  by the unit tests and be replaced with a call to
  NumAvailableFecPackets(). This comes at the (very small) cost
  of calling fec_packets.size() instead of fec_packets.empty().

BUG=webrtc:5654
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Remove FecAvailable(). This member function is only used
  by the unit tests and be replaced with a call to
  NumAvailableFecPackets(). This comes at the (very small) cost
  of calling fec_packets.size() instead of fec_packets.empty().

BUG=webrtc:5654
COMMIT=false
==========

[brandtr, 2016-09-08 08:43:22]

FecAvailable() will be useful in the future. Do not remove.

[brandtr, 2016-09-08 08:44:09]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Remove FecAvailable(). This member function is only used
  by the unit tests and be replaced with a call to
  NumAvailableFecPackets(). This comes at the (very small) cost
  of calling fec_packets.size() instead of fec_packets.empty().

BUG=webrtc:5654
COMMIT=false
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
COMMIT=false
==========

[brandtr, 2016-09-08 08:44:30]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
COMMIT=false
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
COMMIT=false  # Remove after new lgtm.
==========

[brandtr, 2016-09-21 10:54:14]

Rebase.

[brandtr, 2016-09-26 14:09:27]

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec.cc (left):

https://codereview.webrtc.org/2305793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec.cc:212: return
generated_fec_packets_.size();
On 2016/09/05 14:58:38, brandtr wrote:
> On 2016/09/05 14:52:36, stefan-webrtc (holmer) wrote:
> > On 2016/09/05 14:50:20, stefan-webrtc (holmer) wrote:
> > > Since generated_fec_packets_ is a list, this method may run in linear time
> > > compared to the one you removed which is constant. Maybe it's worth
keeping
> > it?
> > > Or remove NumAvailableFecPackets instead?
> > 
> > Or actually since it's only tests, I'm ok with doing as you've done.
> 
> NumAvailableFecPackets() is used by RTPSenderVideo to allocate sequence
numbers
> for the RED packets, so that's needed. I'll remove FecAvailable() :)

Sorry for the flip-flopping here, but I decided to keep the FecAvailable method
around. It will be used in the FlexfecSender/RTPSenderVideo integration, which
was not finalized when I submitted this CL.

[brandtr, 2016-09-27 08:23:00]

Rebase.

[brandtr, 2016-10-03 12:10:00]

Rebase.

[brandtr, 2016-10-04 06:48:21]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
COMMIT=false  # Remove after new lgtm.
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

[brandtr, 2016-10-04 06:48:33]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 06:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-04 06:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 06:49:53]

Dry run: Try jobs failed on following builders:
  ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/1126)
  ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11217)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13521)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/17443)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[brandtr, 2016-10-04 07:09:07]

Rebase.

[brandtr, 2016-10-04 07:09:21]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-04 07:09:22]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2305793003/#ps160001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-10-04 07:09:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2016-10-04 07:16:48]

Fix fuzzer.

[brandtr, 2016-10-04 07:17:33]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-04 07:17:33]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2305793003/#ps180001 (title:
"Fix fuzzer.")

[commit-bot: I haz the power, 2016-10-04 07:17:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2016-10-04 08:53:51]

The CQ bit was unchecked by brandtr@webrtc.org

[brandtr, 2016-10-04 08:57:51]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c07ebb30c530888dc56a6d70c...
==========

[commit-bot: I haz the power, 2016-10-04 08:57:51]

Description was changed from

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
==========

to

==========
Simplify public interface of ProducerFec.

- Change some member functions to be private. These were only
  called by other private member functions.
- Replace DeleteMediaPackets() with direct calls to
  media_packets_.clear()
- Rename GetFecPacketsAsRed to GetUlpfecPacketsAsRed.

No functional changes are intended by this CL.

BUG=webrtc:5654
R=stefan@webrtc.org

Committed: https://crrev.com/c07ebb30c530888dc56a6d70cd5537336fdf12c2
Cr-Commit-Position: refs/heads/master@{#14491}
==========

[commit-bot: I haz the power, 2016-10-04 08:57:52]

Patchset 9 (id:??) landed as
https://crrev.com/c07ebb30c530888dc56a6d70cd5537336fdf12c2
Cr-Commit-Position: refs/heads/master@{#14491}

[brandtr, 2016-10-04 08:57:52]

Committed patchset #9 (id:180001) manually as
c07ebb30c530888dc56a6d70cd5537336fdf12c2 (presubmit successful).