Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2312603003: Remove stop method from VideoTrackSourceInterface. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove stop method from VideoTrackSourceInterface. This method is no longer needed. Follow-up on CL: https://codereview.webrtc.org/2306013002/ Committed: https://crrev.com/859e86107d71e7702651e2a2f738b7ff2fd58be0 Cr-Commit-Position: refs/heads/master@{#14085} BUG=webrtc:6318

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M webrtc/api/androidvideotracksource.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/videocapturertracksource.h View 2 chunks +2 lines, -2 lines 1 comment Download
M webrtc/api/videosourceproxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videotracksource.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
sakal
4 years, 3 months ago (2016-09-05 10:40:07 UTC) #3
sakal
PTAL
4 years, 3 months ago (2016-09-05 10:40:17 UTC) #4
tommi
lgtm
4 years, 3 months ago (2016-09-05 13:14:11 UTC) #5
magjed_webrtc
lgtm nit: The title is misspelled, add a 'c' in VideoTrakSourceInterface. https://codereview.webrtc.org/2312603003/diff/1/webrtc/api/videocapturertracksource.h File webrtc/api/videocapturertracksource.h (right): ...
4 years, 3 months ago (2016-09-05 14:25:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2312603003/1
4 years, 3 months ago (2016-09-06 09:12:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 09:25:11 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/859e86107d71e7702651e2a2f738b7ff2fd58be0 Cr-Commit-Position: refs/heads/master@{#14085}
4 years, 3 months ago (2016-09-06 09:25:18 UTC) #17
tommi
since this cl does modify the public API, I think we should have a bug ...
4 years, 3 months ago (2016-09-06 13:15:38 UTC) #18
sakal
4 years, 3 months ago (2016-09-06 13:22:28 UTC) #20
Message was sent while issue was closed.
On 2016/09/06 13:15:38, tommi (webrtc) wrote:
> since this cl does modify the public API, I think we should have a bug for
> tracking it

Done.

https://bugs.chromium.org/p/webrtc/issues/detail?id=6318

Powered by Google App Engine
This is Rietveld 408576698