Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: webrtc/api/videocapturertracksource.h

Issue 2312603003: Remove stop method from VideoTrackSourceInterface. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/mediastreaminterface.h ('k') | webrtc/api/videosourceproxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 bool is_screencast() const override { 51 bool is_screencast() const override {
52 return video_capturer_->IsScreencast(); 52 return video_capturer_->IsScreencast();
53 } 53 }
54 rtc::Optional<bool> needs_denoising() const override { 54 rtc::Optional<bool> needs_denoising() const override {
55 return needs_denoising_; 55 return needs_denoising_;
56 } 56 }
57 57
58 bool GetStats(Stats* stats) override; 58 bool GetStats(Stats* stats) override;
59 59
60 void Stop() override;
61
62 protected: 60 protected:
63 VideoCapturerTrackSource(rtc::Thread* worker_thread, 61 VideoCapturerTrackSource(rtc::Thread* worker_thread,
64 cricket::VideoCapturer* capturer, 62 cricket::VideoCapturer* capturer,
65 bool remote); 63 bool remote);
66 virtual ~VideoCapturerTrackSource(); 64 virtual ~VideoCapturerTrackSource();
67 void Initialize(const webrtc::MediaConstraintsInterface* constraints); 65 void Initialize(const webrtc::MediaConstraintsInterface* constraints);
68 66
69 private: 67 private:
68 void Stop();
magjed_webrtc 2016/09/05 14:25:42 This function is only called in one place. You can
69
70 void OnStateChange(cricket::VideoCapturer* capturer, 70 void OnStateChange(cricket::VideoCapturer* capturer,
71 cricket::CaptureState capture_state); 71 cricket::CaptureState capture_state);
72 72
73 rtc::Thread* signaling_thread_; 73 rtc::Thread* signaling_thread_;
74 rtc::Thread* worker_thread_; 74 rtc::Thread* worker_thread_;
75 rtc::AsyncInvoker invoker_; 75 rtc::AsyncInvoker invoker_;
76 std::unique_ptr<cricket::VideoCapturer> video_capturer_; 76 std::unique_ptr<cricket::VideoCapturer> video_capturer_;
77 bool started_; 77 bool started_;
78 cricket::VideoFormat format_; 78 cricket::VideoFormat format_;
79 rtc::Optional<bool> needs_denoising_; 79 rtc::Optional<bool> needs_denoising_;
80 }; 80 };
81 81
82 } // namespace webrtc 82 } // namespace webrtc
83 83
84 #endif // WEBRTC_API_VIDEOCAPTURERTRACKSOURCE_H_ 84 #endif // WEBRTC_API_VIDEOCAPTURERTRACKSOURCE_H_
OLDNEW
« no previous file with comments | « webrtc/api/mediastreaminterface.h ('k') | webrtc/api/videosourceproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698