Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Side by Side Diff: webrtc/api/androidvideotracksource.h

Issue 2312603003: Remove stop method from VideoTrackSourceInterface. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/mediastreaminterface.h » ('j') | webrtc/api/videocapturertracksource.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 27
28 namespace webrtc { 28 namespace webrtc {
29 29
30 class AndroidVideoTrackSource : public Notifier<VideoTrackSourceInterface> { 30 class AndroidVideoTrackSource : public Notifier<VideoTrackSourceInterface> {
31 public: 31 public:
32 AndroidVideoTrackSource(rtc::Thread* signaling_thread, 32 AndroidVideoTrackSource(rtc::Thread* signaling_thread,
33 JNIEnv* jni, 33 JNIEnv* jni,
34 jobject j_egl_context, 34 jobject j_egl_context,
35 bool is_screencast = false); 35 bool is_screencast = false);
36 36
37 // Not used on Android.
38 // TODO(sakal/magjed): Try to remove this from the interface.
39 void Stop() override { RTC_NOTREACHED(); };
40
41 bool is_screencast() const override { return is_screencast_; } 37 bool is_screencast() const override { return is_screencast_; }
42 38
43 // Indicates that the encoder should denoise video before encoding it. 39 // Indicates that the encoder should denoise video before encoding it.
44 // If it is not set, the default configuration is used which is different 40 // If it is not set, the default configuration is used which is different
45 // depending on video codec. 41 // depending on video codec.
46 rtc::Optional<bool> needs_denoising() const override { 42 rtc::Optional<bool> needs_denoising() const override {
47 return rtc::Optional<bool>(false); 43 return rtc::Optional<bool>(false);
48 } 44 }
49 45
50 // Returns false if no stats are available, e.g, for a remote 46 // Returns false if no stats are available, e.g, for a remote
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 int* crop_width, 109 int* crop_width,
114 int* crop_height, 110 int* crop_height,
115 int* crop_x, 111 int* crop_x,
116 int* crop_y, 112 int* crop_y,
117 int64_t* translated_camera_time_us); 113 int64_t* translated_camera_time_us);
118 }; 114 };
119 115
120 } // namespace webrtc 116 } // namespace webrtc
121 117
122 #endif // WEBRTC_API_ANDROIDVIDEOTRACKSOURCE_H_ 118 #endif // WEBRTC_API_ANDROIDVIDEOTRACKSOURCE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/mediastreaminterface.h » ('j') | webrtc/api/videocapturertracksource.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698