Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2310043002: Reland of Delete cricket::VideoFrame::GetTimeStamp. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2306953002/ ) Reason for revert: Will reland after downstream projects are updated. Original issue's description: > Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2305623002/ ) > > Reason for revert: > Broke downstream project. > > Original issue's description: > > Delete cricket::VideoFrame::GetTimeStamp. > > > > TBR=tkchin@webrtc.org # Trivial change to VideoRendererAdapter > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 > > Cr-Commit-Position: refs/heads/master@{#14037} > > TBR=perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/bca69e87de5df290f728833a4b3d8af3ae5d88e6 > Cr-Commit-Position: refs/heads/master@{#14038} TBR=perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5682 Committed: https://crrev.com/fa1ba19c5c7c57c8d16fae1a5da51877770fd53e Cr-Commit-Position: refs/heads/master@{#14089}

Patch Set 1 #

Patch Set 2 : Manual rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M webrtc/media/base/fakevideorenderer.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
nisse-webrtc
Created Reland of Delete cricket::VideoFrame::GetTimeStamp.
4 years, 3 months ago (2016-09-06 09:42:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310043002/1
4 years, 3 months ago (2016-09-06 09:51:09 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/191) ios64_gyp_rel on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-09-06 09:52:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310043002/150001
4 years, 3 months ago (2016-09-06 09:59:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16374)
4 years, 3 months ago (2016-09-06 10:53:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2310043002/150001
4 years, 3 months ago (2016-09-06 10:55:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:150001)
4 years, 3 months ago (2016-09-06 11:46:21 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fa1ba19c5c7c57c8d16fae1a5da51877770fd53e Cr-Commit-Position: refs/heads/master@{#14089}
4 years, 3 months ago (2016-09-06 11:46:30 UTC) #14
nisse-webrtc
4 years, 3 months ago (2016-09-06 12:13:28 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:150001) has been created in
https://codereview.webrtc.org/2315703002/ by nisse@webrtc.org.

The reason for reverting is: Broke Chrome fyi bots. See, e.g., 

https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...

Use of GetTimeStamp must be eliminated in Chrome before relanding..

Powered by Google App Engine
This is Rietveld 408576698