Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2306953002: Revert of Delete cricket::VideoFrame::GetTimeStamp. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2305623002/ ) Reason for revert: Broke downstream project. Original issue's description: > Delete cricket::VideoFrame::GetTimeStamp. > > TBR=tkchin@webrtc.org # Trivial change to VideoRendererAdapter > BUG=webrtc:5682 > > Committed: https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 > Cr-Commit-Position: refs/heads/master@{#14037} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/bca69e87de5df290f728833a4b3d8af3ae5d88e6 Cr-Commit-Position: refs/heads/master@{#14038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M webrtc/media/base/fakevideorenderer.h View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 4 chunks +4 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nisse-webrtc
Created Revert of Delete cricket::VideoFrame::GetTimeStamp.
4 years, 3 months ago (2016-09-02 09:06:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306953002/1
4 years, 3 months ago (2016-09-02 09:06:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 09:07:06 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bca69e87de5df290f728833a4b3d8af3ae5d88e6 Cr-Commit-Position: refs/heads/master@{#14038}
4 years, 3 months ago (2016-09-02 09:07:18 UTC) #6
nisse-webrtc
4 years, 3 months ago (2016-09-06 09:42:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2310043002/ by nisse@webrtc.org.

The reason for reverting is: Will reland after downstream projects are updated..

Powered by Google App Engine
This is Rietveld 408576698