Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2305623002: Delete cricket::VideoFrame::GetTimeStamp. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete cricket::VideoFrame::GetTimeStamp. TBR=tkchin@webrtc.org # Trivial change to VideoRendererAdapter BUG=webrtc:5682 Committed: https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 Cr-Commit-Position: refs/heads/master@{#14037}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M webrtc/media/base/fakevideorenderer.h View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 22 (11 generated)
nisse-webrtc
Please have a look. I don't think it's used downstream.
4 years, 3 months ago (2016-09-01 13:03:41 UTC) #6
perkj_webrtc
lgtm https://codereview.webrtc.org/2305623002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm File webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm (right): https://codereview.webrtc.org/2305623002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm#newcode33 webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm:33: timeStampNs:nativeVideoFrame.timestamp_us() * is RTCVideoFrame using ns?
4 years, 3 months ago (2016-09-01 13:44:45 UTC) #7
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-01 13:44:55 UTC) #8
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-01 13:44:56 UTC) #9
nisse-webrtc
https://codereview.webrtc.org/2305623002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm File webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm (right): https://codereview.webrtc.org/2305623002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm#newcode33 webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm:33: timeStampNs:nativeVideoFrame.timestamp_us() * On 2016/09/01 13:44:44, perkj_webrtc wrote: > is ...
4 years, 3 months ago (2016-09-01 13:50:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2305623002/1
4 years, 3 months ago (2016-09-01 13:51:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-01 15:52:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2305623002/1
4 years, 3 months ago (2016-09-02 08:01:23 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 08:33:58 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 Cr-Commit-Position: refs/heads/master@{#14037}
4 years, 3 months ago (2016-09-02 08:34:11 UTC) #21
nisse-webrtc
4 years, 3 months ago (2016-09-02 09:06:49 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2306953002/ by nisse@webrtc.org.

The reason for reverting is: Broke downstream project..

Powered by Google App Engine
This is Rietveld 408576698